Create migration path for form_error alert banners
What does this MR do and why?
The form_error
helper currently produces alert-style banners which are not in line with the Pajamas design system.
This MR provides an option to render the form errors using Pajamas::AlertComponent
which utilizes the Vue GlAlert
DOM structure.
The idea behind this is to allow for individual migration of each of the 120+ instances of form_error
in which specs can be fixed and changes can be inspected for visual regressions or other side effects, as opposed to migrating everything all at once.
Once each instance of form_errors
has been migrated, Pajamas will become the default and the option will be removed.
Screenshots
Single error
before | after |
---|---|
How to set up and validate locally
- Navigate to
Project => Wiki
- Click
Create a new wiki page
- Put in a title that is > 255chars
- Click
Create
- Observe error message
Multiple errors
before | after |
---|---|
How to set up and validate locally
- Navigate to
Admin => Deploy Keys => Click "Add Deploy Key"
- Click
Create
without filling anything out - Observe multiple errors
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Part of: #294442 (closed) and &5550 (closed)