Add timestamp columns to VSA aggregated RecordsFetcher
Resolves #364361 (closed)
The aggregated version of the VSA RecordsFetcher
, used at group level, was missing the start_event_timestamp
and end_event_timestamp
columns. As a result, such attributes were always null in the JSON response to Projects::Analytics::CycleAnalytics::StagesController#records
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364361 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @m_frankiewicz
removed [deprecated] Accepting merge requests label
removed priority1 label
removed severity3 label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @ck3g
,@pshutsin
,@ekigbo
,@proglottis
,@engwan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Brian Williams ( @bwill
) (UTC-5, 7 hours behind@m_frankiewicz
)Heinrich Lee Yu ( @engwan
) (UTC+8, 6 hours ahead of@m_frankiewicz
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangermentioned in issue #364361 (closed)
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 0b5988a9expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Manage | 36 | 0 | 2 | 37 | 38 | ❗ | | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Secure | 6 | 0 | 0 | 6 | 6 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 127 | 0 | 9 | 127 | 136 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 4c9122b1 - Add start_event_timestamp and end_event_timestamp in order_by_duration
- Resolved by Pavel Shutsin
requested review from @ahegyi
added 1 commit
- 0b5988a9 - Add start_event_timestamp and end_event_timestamp in order_by_duration
added databaseapproved label
@ahegyi
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Pavel Shutsin
@m_frankiewicz, did you verify both project and group-level views? Are they loading?
added workflowin review label
- Resolved by Pavel Shutsin
@stanhu could you do maintainer review please?
requested review from @stanhu
removed review request for @stanhu
requested review from @pshutsin
mentioned in issue #353554 (closed)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for a5cca9c9 succeeds
removed review request for @pshutsin
mentioned in commit 7b4e9849
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedpublished label
mentioned in merge request kubitus-project/kubitus-installer!1153 (merged)
added releasedcandidate label and removed releasedpublished label