Skip to content

Move population of QA_TESTS var into a separate job

Sanad Liaquat requested to merge qa-shl-populate-qa-tests-job-take-2 into master

What does this MR do and why?

This was originally implemented in !89312 (merged) and but was reverted due to it causing pipeline failures due to lack of rules. This MR adds the rules.

Here is why extending .qa:rules:package-and-qa should work. Copied my comment:

  1. The code in populate-qa-tests-var was moved from package-and-qa-base whose inheritors use .qa:rules:package-and-qa.
  2. Comparing code patterns covered in .qa:rules:package-and-qa and .rails:rules:detect-tests:
  • .rails:rules:detect-tests covers workhorse-patterns and code-backstage-qa-patterns.
  • .qa:rules:package-and-qa covers nodejs-patterns, ci-qa-patterns, qa-patterns and code-patterns. All of these are a subset of code-backstage-qa-patterns. So we should be fine with extending .qa:rules:package-and-qa

Orignal Description:

As part of https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/1287, we need QA_TESTS to determine if package-and-qa should be run. For this purpose, this MR moves the population of QA_TESTS to a separate job in prepare stage.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sanad Liaquat

Merge request reports