Skip to content

Fix secondary storage namespace for duplicate jobs

Alejandro Rodríguez requested to merge redis-multistore-fixes into master

What does this MR do and why?

In !85740 (merged) we introduced a MultiStore to transition duplicate jobs data from Sidekiq.redis to SharedState. We used the Gitlab::Redis::Queues store to point to the current data, but omitted that Sidekiq.redis is namespaced. This is actually an existing mishap, in that with the current state keys are actually stored under "resque:gitlab:resque:gitlab:duplicate:". We add the namespace to the Queues store for compatibility with the current state, but leave SharedState with no namepsace so keys that land there have proper format.

We also fix the extra data format in the error log messages.

Part of gitlab-com/gl-infra/scalability#925 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alejandro Rodríguez

Merge request reports