Add clusterAgents field to Project/Group/Security Dashboard GraphQL API
What does this MR do and why?
We're adding ability to filter vulnerabilities based on Kubernetes Agent, so you will be able to see vulnerabilities created for selected cluster (using cluster-image-scanning
capabilities).
Queries
Group query
explain SELECT "cluster_agents".* FROM "cluster_agents" WHERE "cluster_agents"."project_id" IN (SELECT "projects"."id" FROM "projects" WHERE "projects"."namespace_id" IN (WITH RECURSIVE "base_and_descendants" AS ((SELECT "namespaces"."id" FROM "namespaces" WHERE "namespaces"."type" = 'Group' AND "namespaces"."id" = 9970)
UNION
(SELECT "namespaces"."id" FROM "namespaces", "base_and_descendants" WHERE "namespaces"."type" = 'Group' AND "namespaces"."parent_id" = "base_and_descendants"."id")) SELECT "namespaces"."id" FROM "base_and_descendants" AS "namespaces"))
Summary:
Time: 531.206 ms
- planning: 9.113 ms
- execution: 522.093 ms
- I/O read: 491.574 ms
- I/O write: 0.000 ms
Shared buffers:
- hits: 10216 (~79.80 MiB) from the buffer pool
- reads: 1356 (~10.60 MiB) from the OS file cache, including disk I/O
- dirtied: 186 (~1.50 MiB)
- writes: 0
Details and visualization: https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/10542/commands/37862.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to GraphQL filter for vulnerabilities by container... (#358763 - closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @mparuszewski
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rymai
,@sabrams
,@gitlab-bot
,@ahegyi
,@kushalpandya
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- Resolved by Terri Chu
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serena Fang ( @serenafang
) (UTC-5, 7 hours behind@mparuszewski
)Heinrich Lee Yu ( @engwan
) (UTC+8, 6 hours ahead of@mparuszewski
)database Dylan Griffith ( @DylanGriffith
) (UTC+10, 8 hours ahead of@mparuszewski
)Mayra Cabrera ( @mayra-cabrera
) (UTC-5, 7 hours behind@mparuszewski
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 540e8e98expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Secure | 4 | 0 | 0 | 4 | 4 | ❗ | | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Manage | 37 | 0 | 2 | 38 | 39 | ❗ | | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 126 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
added 122 commits
-
ba963bc9...67f138f7 - 120 commits from branch
master
- 7322ff7f - Add clusterAgents field to Project/Group/Security Dashboard GraphQL API
- 09b49c72 - Add missing specs
-
ba963bc9...67f138f7 - 120 commits from branch
added 98 commits
-
09b49c72...ad98d59d - 96 commits from branch
master
- 70b47588 - Add clusterAgents field to Project/Group/Security Dashboard GraphQL API
- d00b2482 - Add missing specs
-
09b49c72...ad98d59d - 96 commits from branch
added 1 commit
- 3aadbb11 - Add clusterAgents field to Project/Group/Security Dashboard GraphQL API
added 723 commits
-
3aadbb11...002a5984 - 722 commits from branch
master
- 2b577584 - Add clusterAgents field to Project/Group/Security Dashboard GraphQL API
-
3aadbb11...002a5984 - 722 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @cat and @sashi_kumar
added databasereviewed label
@cat
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Terri Chu
added databaseapproved label and removed databasereviewed label
removed review request for @sabrams
requested review from @terrichu and removed review request for @sashi_kumar
mentioned in merge request !90187 (merged)
- Resolved by Achilleas Pipinellis
@axil would you mind a documentation review?
requested review from @axil
- Resolved by Terri Chu
- Resolved by Terri Chu
removed review request for @terrichu
requested review from @dblessing
removed review request for @dblessing
requested review from @dblessing and @terrichu
added 1261 commits
-
3dbbfa02...e827dc63 - 1258 commits from branch
master
- fa7bd718 - Add clusterAgents field to Project/Group/Security Dashboard GraphQL API
- 208e362b - Address MR comments
- 9268d351 - Add missing spec
Toggle commit list-
3dbbfa02...e827dc63 - 1258 commits from branch
added Technical Writing docsfeature twfinished labels
removed review request for @axil
changed milestone to %15.2
added missed:15.1 label
added 1 commit
- 540e8e98 - Remove read_cluster permission from instance dashboard
removed review request for @dblessing
@mparuszewski thanks for applying the feedback, I'm going to approve and set mwps
added workflowin review label and removed workflowin dev label
enabled an automatic merge when the pipeline for daca503d succeeds