Add FF for graphQL variables in settings
What does this MR do and why?
Adds the basic skeleton for the variables settings that we want to migrate to graphQL. The diff looks bigger than it is because we are duplicating files. Tests will be introduced when the GraphQL app can actually render things
- Add FF in the controller and in
index.js
- In index.js, add a new mounting method for creating the component with apollo and
provide
static values instead of passing them to the VueX store - Copy files that will need to be re-written for apollo
- Prefix file with
legacy_
to make it clear that these will eventually be deleted - Remove the components from the new apollo root component. They will be added once sub-components are working with apollo in a following MR
This is behind a ff, ci_variable_settings_graphql
Screenshots or screen recordings
With FF off | With FF on |
---|---|
How to set up and validate locally
- Navigate to
Settings => CI/CD
- Expand the variables section
- Add variables
- Edit them
- Remove them
- Notice that all functionality still works as intended
- Open the rails console
rails c
- enable the feature flag `Feature.enable(:variable_settings_graphql)
- Navigate to
Settings => CI/CD
- Expand the variable section
- Notice the Add button is missing (yay!)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364375 (closed)
Edited by Frédéric Caplette