Remove expect not_to raise_error code blocks from personal_project_permissions_spec

What does this MR do and why?

Removes the expect do ... end.not_to raise_error code blocks from the private methods within personal_project_permissions_spec.rb to avoid obscure error messages and help with debugging.

Also updates the E2E Best Practices docs with a section recommending avoiding using this technique in the future.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.