Create Selector with Sidebar component for CI CD Configuration
What does this MR do and why?
This MR resolves #364123 (closed)
New scanner and site profiles selectors together with new create/edit/select flow from the sidebar are used in On Demand Scans Form
According to new design , same flow has to be used in security configuration enabling DAST form.
Based on that requirement shared functionality was moved to dast_profiles_configurator.vue component and was successfully reused in both
ee/app/assets/javascripts/security_configuration/dast/components/configuration_form.vue (90059) and
ee/app/assets/javascripts/on_demand_scans_form/components/on_demand_scans_form.vue
This mR is only dedicated to extracting functionality to dast_profiles_configurator.vue component
It is now behind feature flag and as soon it is rolled out, extra code marked with TODOs can be removed from on_demand_scans_form in next iteration
Localstorage caching was removed as it is no longer needed according to new flow
Describe in detail what your merge request does and why.
Screenshots or screen recordings
| after |
|---|
| ondemand |
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
- Enable feature flag
Feature.enable(:dast_ui_redesign)- Go to
URL/root/PROJECT_ID/-/on_demand_scans/new - Or Go to
URL/root/PROJECT_ID/-/on_demand_scans/$ON_DEMAND_SCAN_ID/edit - And Go to
URL/root/PROJECT_ID/-/security/configuration/dast
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.