Skip to content

Fix flaky quarantined test

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/363136/fix-quarantined-test into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR reverts !89183 (merged) and fixes the quarantined test that could be reproduced by running bundle exec rspec ee/spec/services/ee/members/create_service_spec.rb ee/spec/services/ci/runners/reset_registration_token_service_spec.rb (thanks @kwiebers for finding the winning combination!).. I don't yet know why, but saving the :application_setting after having executed the last spec in ee/spec/services/ee/members/create_service_spec.rb causes the error. This MR sidesteps the problem by avoiding persisting the :application_setting, replacing create(:application_setting) with build(:application_setting).

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #363136 (closed)

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports