Refactor bulk items into standard member creator
What does this MR do and why?
- Moves the 'Bulk' member creation logic out of
BulkCreatorService
and into the basicCreatorService
. - Removes the
BulkCreatorService
and will have all member creation rely on theBulk
setup instead. - Preps the future work of reducing queries on member creation by enabling moving of logic from
CreatorService
itself into a class method like some of what is done in the class method.add_users
today.- future work on queries - #354016 (closed)
- Reduces n+1 queries for inviting emails adding them to the
existing_members
logic and contributes towards #354016 (closed) - Enables re-inviting/adding a member by email as a requester if they already exist - #358626 (closed)
- Ensures all uses of the
CreatorService
go through theadd_users
class method to ensureexisting_members
is found and forgoing the need to usefind_or_initialize_by
in theCreator
itself.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #339870 (closed)
Edited by Doug Stull