Skip to content

Draft: Refactor `owned_by?` method

charlie ablett requested to merge cablett/refactor-owned-by-method into master

What does this MR do and why?

I saw that we have some methods for 'does this person own this thing' and I wanted to make this one as clear as possible. It only means direct owners, but then we can phase out other 'does this person own this thing' methods to make it all consistent.

  • Rename to directly_owned_by? for clarity

  • Remove from Routable concern and into Namespace

  • Add method to Project so it includes direct Project owners

  • Delegate ProjectNamespace owners to Project owners

How to set up and validate locally

Refactor - there should be no change of behaviour

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #364492 (closed) and &7405

Edited by charlie ablett

Merge request reports