Show Terraform state deleted status in UI
What does this MR do and why?
When a Terraform state is marked for deletion, there is a (usually) short window where the state will still show in the UI because the background worker hasn't finished removing it yet. To show this, we add a badge similar to when a state is locked.
Screenshots or screen recordings
How to set up and validate locally
- Using the Rails console, create a Terraform state that is marked for deletion:
> Terraform::State.create!(project_id: <project-id>, name: 'test-state', deleted_at: Time.current)
- Visit http://path/to/project/-/terraform
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #349011 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @tigerwnz
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @kerrizor
,@jivanvl
,@reprazent
,@psimyn
,@tigerwnz
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Chad Woolley ( @cwoolley-gitlab
) (UTC-7, 19 hours behind@tigerwnz
)Heinrich Lee Yu ( @engwan
) (UTC+8, 4 hours behind@tigerwnz
)frontend Tom Quirk ( @tomquirk
) (UTC+9.5, 2.5 hours behind@tigerwnz
)Jacques Erasmus ( @jerasmus
) (UTC+2, 10 hours behind@tigerwnz
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerremoved typebug label
added typebug label
removed SLOMissed label
removed SLONear Miss label
removed typebug label
removed severity2 label
added typebug label
removed priority2 label
removed typebug label
added typebug label
removed typebug label
added typebug label
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 06d2b065expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Plan | 41 | 0 | 1 | 41 | ❗ | | Create | 22 | 0 | 3 | 23 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Manage | 35 | 0 | 3 | 38 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 112 | 0 | 11 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Frédéric Caplette
@anna_vovchenko and @hfyngvason can you please review for frontend/backend?
requested review from @anna_vovchenko and @hfyngvason
mentioned in issue #349011 (closed)
requested review from @f_caplette and removed review request for @anna_vovchenko
@anna_vovchenko
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f284467b and 06d2b065
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.46 MB - 0.0 % mainChunk 1.93 MB 1.93 MB - 0.0 %
Note: We do not have exact data for f284467b. So we have used data from: 2a7fe8fb.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Frédéric Caplette
- Resolved by Frédéric Caplette
- Resolved by Frédéric Caplette
removed review request for @f_caplette
requested review from @robotmay_gitlab and removed review request for @hfyngvason
added 235 commits
-
9a7ed7ae...97d29dc2 - 233 commits from branch
master
- 58b63b01 - Show Terraform state deleted status in UI
- 06d2b065 - Use tooltip directive instead of component in Terraform states table
-
9a7ed7ae...97d29dc2 - 233 commits from branch
requested review from @f_caplette and removed review request for @robotmay_gitlab
enabled an automatic merge when the pipeline for c6dfcb4f succeeds
mentioned in commit 10f59616