Fixes focus border is cutoff on downstream cards
What does this MR do and why?
We recently fixed the browser selection border on the expand button for upstream/downstream pipelines. However when expanding the graph, the new appended section (aka, the (up/down)stream pipeline cuts off the border. To fix this, we add some padding to the cards.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Setup gitlab runners locally https://docs.gitlab.com/runner/install/osx.html#install-gitlab-runner-on-macos
- Create at least 2 projects which have their own CI configuration (examples of config will be seen below)
- Add a new runner for both of these projects
- In the main project, setup the main .gitlab-ci.yml file by navigating to
CI/CD => Editor
- Paste the following config (and adjust the project names to match)
stages:
- build
- test
- deploy
hi:
stage: "build"
script: "echo simple job"
trigger_simple_yaml:
stage: deploy
trigger:
include:
- project: "root/simple-yaml" # replace with your 2nd project
file: ".gitlab-ci.yml"
- Then go inside your second project CI configuration by navigating to
CI/CD => Editor
- Paste any configuration you like:
job_from_project_2:
script: echo hello from project 2
- Go back to Project 1
- Run a pipeline
- The downstream card will appear in the graph
- Tab through the content until you are on the expand button of the downstream card (The button with a right arrow!)
- Notice the blue border appears
- Press enter to expand the downstream
- Notice the blue line is not cutoff
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364190 (closed)
Edited by Frédéric Caplette