Skip to content

Danger review roulette for strictly needed CODEOWNERS approvals

Lin Jen-Shin requested to merge 360840-append-approvals-to-roulette into master

What does this MR do and why?

This requires: gitlab-org/ruby/gems/gitlab-dangerfiles!130 (merged)

This will look at the merge request approvals, listing strictly required approvals (approvals_required > 0) in the Danger roulette table.

It'll randomly pick one from the eligible_approvers list. It also follows regular roulette rules that excluding unavailable people and stick to the same candidate unless they become unavailable.

TODO:

Screenshots or screen recordings

Approvals widget

Screenshot_2022-06-08_at_17.01.46

Danger roulette table

Screenshot_2022-06-09_at_12.54.07

How to set up and validate locally

You can't 😆 .

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #360840 (closed)

Feedback issue: gitlab-org/quality/engineering-productivity/team#57 (closed)

Edited by Lin Jen-Shin

Merge request reports