Skip to content

Use ci-icon on right sidebar on Job detail (Projects::JobsController#show)

What does this MR do and why?

Uses <ci-icon :size="14"> instead of bare CSS on right sidebar on Job detail (GET /:namespace/:project/-/jobs/:id or Projects::JobsController#show).

Removing CSS is blocked by !89002 (merged)

Screenshots or screen recordings

before after
before-mr-88993 after-mr-88993
Margin right to the sidebar area is artifact on taking a screenshot.
Taken from https://gitlab.com/gitlab-org/gitlab/-/jobs/2531276379 Taken from https://gitlab-review-364079-tni-1s5zp3.gitlab-review.app/gitlab-qa-sandbox-group-4/qa-test-2022-06-01-08-08-27-320a81d53a31a5e5/pipelines-dependent-relationship-6ff1130bb4c73dcc/-/jobs/9

How to set up and validate on RA

  1. Visit /:namespace/:project/-/jobs/:id on Review Apps for this MR.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Partially updates gitlab-foss!14567 (merged)

Related to #364079 (closed)

Edited by Takuya Noguchi

Merge request reports