Skip to content

Remove unwanted title attribute

Savas Vedova requested to merge 363573-remove-unwanted-span-title-property into master

What does this MR do and why?

Removes the unwanted title property from the span element.

Screenshots or screen recordings

This is gone:

image

How to set up and validate locally

  1. Go to your project
  2. Click on Security & Compliance > Policies > New Policy
  3. Apply the following diff:
diff --git a/ee/app/assets/javascripts/threat_monitoring/components/policy_editor/policy_editor.vue b/ee/app/assets/javascripts/threat_monitoring/components/policy_editor/policy_editor.vue
index 1ba9fa3f645..d4aa516fcaa 100644
--- a/ee/app/assets/javascripts/threat_monitoring/components/policy_editor/policy_editor.vue
+++ b/ee/app/assets/javascripts/threat_monitoring/components/policy_editor/policy_editor.vue
@@ -75,10 +75,7 @@ export default {
 
 <template>
   <section class="policy-editor">
-    <span
-      v-if="namespaceType === $options.NAMESPACE_TYPES.GROUP"
-      data-testid="group-level-notification"
-    >
+    <span data-testid="group-level-notification">
       {{ $options.i18n.groupPolicyMessage }}
     </span>
     <gl-alert

Check that hovering over the text that appears do not display the title.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363573 (closed)

Merge request reports