Skip to content

Improve design loading state

Lee Tickett requested to merge 273132-improve-design-loading-state into master

What does this MR do and why?

When moving between designs the current experience is a bit confusing (no loading state).

This MR significantly improves that by display a loading spinner while the design is loading, and skeleton while the comments are loading.

Screenshots or screen recordings

Before

old-loading-state

After

Designs_loading

How to set up and validate locally

  • Navigate to an issue and upload a few designs
  • Open a design
  • Page between designs (it may be helpful to open chrome dev tools, switch to the network tab and enable throttling to emphasize the changes)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #273132 (closed)

Edited by Lee Tickett

Merge request reports