Skip to content

Refactor runner instructions modal data lazy load

Miguel Rincon requested to merge mrincon-move-modal-lazy-load into master

What does this MR do and why?

The runner registration instructions in the runner registration modal are loaded only when needed.

This change shifts the responsibility for deciding wether or not to load data from the parent of the modal component to the modal itself, making the modal easily reusable.

Screenshots or screen recordings

No changes are expected, this is the related modal:

image

How to set up and validate locally

  1. Log in as admin
  2. Visit the admin -> runners section
  3. Open the dropdown Register an instance runner
  4. Select the option Show runner installation and registration instructions

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miguel Rincon

Merge request reports