Skip to content

Add improved label selection to issues and MRs form

Robert Hunt requested to merge 1269-improve-label-selection into master

What does this MR do and why?

Behind the default off feature flag :visible_label_selection_on_metadata.

This MR updates the creation pages for issues and MRs to render a list of the labels that have been selected by the user. This makes it easier to see what labels have been selected and remove them if needed.

Once this is fully deployed and tested, the creation pages for epics and test cases will also be updated to show the labels selected.

Screenshots or screen recordings

Before After
before after
Empty With labels In action
image image Screen_Recording_2022-06-15_at_09.15.58

How to set up and validate locally

  1. Create a new issue and test that you can select labels and save the form
  2. Create a new MR and test that you can select labels and save the form
  3. Edit the MR and test that you can change the labels and save the form
  4. Turn on the feature flag: echo "Feature.enable(:visible_label_selection_on_metadata)" | rails c
  5. Create a new issue and test that you can select labels, see the list of labels, remove labels from the list, and save the form
  6. Create a new MR and test that you can select labels, see the list of labels, remove labels from the list, and save the form
  7. Edit the MR and test that you can change the labels using the dropdown or removing labels from the list, and save the form

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to gitlab-org/gitlab-services/design.gitlab.com#1269

Edited by Sascha Eggenberger

Merge request reports