Skip to content

Feature flag removal: registry phase 2 throughput feature flags

Steve Abrams requested to merge remove-phase2-throughput-ff into master

What does this MR do and why?

This MR removes two feature flags:

  • container_registry_migration_phase2_enqueue_twice - This feature flag ended up not being used, so we are removing it and it's behavior here.
  • container_registry_migration_phase2_enqueuer_loop - This feature flag has been enabled on GitLab.com since 2022-05-16

Both of these feature flags are involved in the container registry migration where we are moving all container repositories to the new container registry. The entire migration is behind a feature flag as we are only doing this migration on GitLab.com at this time. Self-managed will be handled separately in the future. Since this code continues to be behind a feature flag, I have used a changelog of other rather than added/removed.

I suggest reviewing the changes with the show whitespace changes setting unchecked. There is a large context in one of the specs that just has an indentation change, so it is easier to view without those changes.

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #350543

Edited by Steve Abrams

Merge request reports