Skip to content

Add title attribute to MR approval rule names

Sam White requested to merge sam-add-title-attribute into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR adds the title attribute so that users can view the full MR approval rule name in the scenario where that name is too long to fit on the screen.

This MR addresses customer feedback from https://gitlab.com/gitlab-com/account-management/emea/travis-perkins/tp-pov/-/issues/18#note_957799965

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

Before

image

After

image

How to set up and validate locally

  1. Create a group where you are the group owner. This requires a GitLab Ultimate license.
  2. Create a project in the group "Development Project"
  3. Navigate to the project -> Security & Compliance -> Policies page
  4. Create a new Scan Result policy with a long name
  5. Click "Configure with a merge request". This will create a new "Security Policy Project" in the same group and will open a merge request in that newly created project.
  6. Merge in the auto-generated merge request
  7. Navigate back to your "Development Project" and open a merge request in that project
  8. View the security approval rule on the MR page

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sam White

Merge request reports