Skip to content

Fix Service Ping payload hash key shadowing

Piotr Skorupa requested to merge psk-fix-service-ping-key-shadowing into master

What does this MR do and why?

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/363496.

This converts old Service Ping payload from Gitlab::UsageData to HashWithIndifferentAccess to prevent adding duplicate string and symbol keys on merge with instrumentation class metrics and overriding each other when converted to jsonb and persisted in RawUsageData.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Piotr Skorupa

Merge request reports