Skip to content
Snippets Groups Projects

Include coverage reports from child pipeline

All threads resolved!

What does this MR do and why?

Include coverage reports from child pipelines when creating pipeline coverage report.

Part of #363301 (closed).

Screenshots or screen recordings

In this sample MR, alberts-gitlab/test-ruby-cobertura!2, there is a parent and child pipeline set up to generate coverage. The parent pipeline generates coverage for demo.rb. The child pipeline generates coverage for demo_child.rb.

Before - coverage from child pipeline is not included: Screenshot_2022-05-30_at_5.33.04_PM

After - coverage from child pipeline is included: Screenshot_2022-05-30_at_5.33.27_PM

Example project and MR: alberts-gitlab/test-ruby-cobertura!2

How to set up and validate locally

  1. Clone project https://gitlab.com/alberts-gitlab/test-ruby-cobertura locally
  2. Pull branch https://gitlab.com/alberts-gitlab/test-ruby-cobertura/-/tree/test-coverage-child-pipeline containing CI and test changes to generate coverage from child pipeline.
  3. Create MR in GDK and wait for pipeline to succeed.
  4. Verify that the demo_child.rb coverage generated in the child pipeline is not shown in the MR diff.
  5. Enable feature flag ci_child_pipeline_coverage_reports.
    Feature.enable(:ci_child_pipeline_coverage_reports)
  6. Run a new pipeline on the branch and wait for it to succeed.
  7. Verify that the demo_child.rb coverage is now shown in the MR diff.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Albert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Albert
  • Albert mentioned in issue #363334

    mentioned in issue #363334

  • Allure report

    allure-report-publisher generated test report!

    review-qa-blocking: :exclamation: test report for 6546e574

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Create               | 23     | 0      | 2       | 22    | 25    | ❗     |
    | Manage               | 36     | 0      | 2       | 37    | 38    | ❗     |
    | Plan                 | 41     | 0      | 1       | 41    | 42    | ❗     |
    | Verify               | 12     | 0      | 1       | 12    | 13    | ❗     |
    | Package              | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Configure            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Version sanity check | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Protect              | 2      | 0      | 0       | 2     | 2     | ❗     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 114    | 0      | 9       | 114   | 123   | ❗     |
    +----------------------+--------+--------+---------+-------+-------+--------+

    package-and-qa-ff-enabled: :x: test report for 6546e574

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Secure               | 60     | 0      | 6       | 8     | 66    | ❗     |
    | Plan                 | 159    | 0      | 3       | 0     | 162   | ✅     |
    | Verify               | 120    | 0      | 9       | 0     | 129   | ✅     |
    | Create               | 426    | 21     | 18      | 5     | 465   | ❌     |
    | Release              | 18     | 0      | 0       | 0     | 18    | ✅     |
    | Package              | 0      | 0      | 9       | 0     | 9     | ➖     |
    | Manage               | 303    | 0      | 12      | 0     | 315   | ✅     |
    | Protect              | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Fulfillment          | 6      | 0      | 33      | 0     | 39    | ✅     |
    | Version sanity check | 0      | 0      | 3       | 2     | 3     | ➖     |
    | Configure            | 0      | 0      | 9       | 0     | 9     | ➖     |
    | Product Intelligence | 6      | 0      | 0       | 0     | 6     | ✅     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 1104   | 21     | 102     | 15    | 1227  | ❌     |
    +----------------------+--------+--------+---------+-------+-------+--------+

    package-and-qa-ff-disabled: :x: test report for 6546e574

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Create               | 426    | 21     | 18      | 3     | 465   | ❌     |
    | Plan                 | 159    | 0      | 3       | 0     | 162   | ✅     |
    | Manage               | 303    | 0      | 12      | 0     | 315   | ✅     |
    | Product Intelligence | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Release              | 18     | 0      | 0       | 0     | 18    | ✅     |
    | Verify               | 120    | 0      | 9       | 0     | 129   | ✅     |
    | Configure            | 0      | 0      | 9       | 0     | 9     | ➖     |
    | Fulfillment          | 6      | 0      | 33      | 0     | 39    | ✅     |
    | Package              | 0      | 0      | 9       | 0     | 9     | ➖     |
    | Secure               | 60     | 0      | 6       | 5     | 66    | ❗     |
    | Version sanity check | 0      | 0      | 3       | 1     | 3     | ➖     |
    | Protect              | 6      | 0      | 0       | 0     | 6     | ✅     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 1104   | 21     | 102     | 9     | 1227  | ❌     |
    +----------------------+--------+--------+---------+-------+-------+--------+

    package-and-qa: :exclamation: test report for 3b7366fe

    expand test summary
    +-------------------------------------------------------------------+
    |                          suites summary                           |
    +----------------------+--------+--------+---------+-------+--------+
    |                      | passed | failed | skipped | flaky | result |
    +----------------------+--------+--------+---------+-------+--------+
    | Configure            | 1      | 0      | 15      | 0     | ✅     |
    | Plan                 | 273    | 0      | 0       | 1     | ❗     |
    | Verify               | 190    | 0      | 15      | 66    | ❗     |
    | Package              | 149    | 0      | 30      | 11    | ❗     |
    | Release              | 30     | 0      | 0       | 12    | ❗     |
    | Manage               | 471    | 0      | 30      | 3     | ❗     |
    | Create               | 773    | 0      | 31      | 48    | ❗     |
    | Non-devops           | 11     | 0      | 0       | 0     | ✅     |
    | Secure               | 100    | 0      | 10      | 25    | ❗     |
    | Fulfillment          | 11     | 0      | 55      | 0     | ✅     |
    | Version sanity check | 0      | 0      | 5       | 2     | ➖     |
    | Enablement:Search    | 9      | 0      | 1       | 0     | ✅     |
    | Protect              | 10     | 0      | 0       | 0     | ✅     |
    +----------------------+--------+--------+---------+-------+--------+
    | Total                | 2028   | 0      | 192     | 168   | ❗     |
    +----------------------+--------+--------+---------+-------+--------+
  • Albert marked this merge request as draft

    marked this merge request as draft

  • Albert
  • Albert added 1 commit

    added 1 commit

    • 910c26e8 - WIP: Extract coverage report out of pipeline

    Compare with previous version

  • Albert added 1 commit

    added 1 commit

    • 8a8b10b9 - WIP: Extract coverage report out of pipeline

    Compare with previous version

  • Albert
  • Albert added 1 commit

    added 1 commit

    • 1893377f - WIP: Extract coverage report out of pipeline and build

    Compare with previous version

  • Albert added 1 commit

    added 1 commit

    • 3ff26ed4 - WIP: Extract coverage report out of pipeline and build

    Compare with previous version

  • Albert added 410 commits

    added 410 commits

    • 463d17b8 - Feat: add prepend to devise failure
    • dc3dfed4 - Improve tw:codeowners task
    • 427fe77c - Fix problems with GitPod with custom fork names
    • eaab08ad - Fix custom notification settings for releases
    • eb625a5a - Add trailing / to directories
    • 8e8f2ab0 - Convert git strategy radio buttons in Project CI/CD settings
    • b3a43a36 - Disable MD5 usage in go packages when in fips mode
    • 3128d2fe - Remove DastSiteValidationWorker
    • 8b7723b7 - Database Dictionary Audit for Release:Release
    • 08a51efe - Hint to run finalize command in a compatible shell
    • bcc04780 - Updates description of dast related yml files
    • 093a152e - Cleanup unused issue workers
    • 439c992a - Use the same pattern format for CODEOWNERS generation
    • 23e3dd71 - Rename Projects::ServicesController and change routes
    • b100129e - Use format correctly
    • 4eefe559 - Keep supporting legacy `/-/integrations` routes, add specs
    • 53277e97 - Migrate button in alert for mermaid limit
    • df3f217e - Change next_aborted_repository `take` to `limit(2)[0]`
    • 517d8d88 - Makes subscriber idempotent and adds shared example
    • 87ab4b4b - Removes unnecessary spec
    • b192c097 - Migrate the lock button in the sidebar
    • 41b8ff54 - Sort projects by CI minutes usage in Usage Quotas page
    • f571b041 - Add type to IssueLinks internal API
    • 7d40c1a5 - Migrates the button to add approval rule
    • ca2c3c7e - Remove 'group_projects_api_preload_groups' feature flag
    • 91132420 - Use request cache for protected tags
    • b808a27e - Fix callouts test
    • 58ba863c - Remove unreachable clusters controller code
    • 40ae54ee - Align DAST Site Token URL validation
    • ed07cfe2 - Remove unused code quality report path
    • d628fc2a - Don't fail extension API getter
    • 6ee32fe6 - Add basic issue popover
    • 31e49801 - Fixed merge request header not staying in container
    • 61bd6e37 - Fix invalid nextTick() calls
    • a1a9b9ba - Remove ExpirePipelineCacheWorker and ExpireJobCacheWorker
    • 5a435672 - Improve design consistency of buttons in some modals
    • a18f4944 - Add end_event_timestamp to the stage records JSON response
    • bae2e6e8 - Update minimum version of grape_logging in Gemfile to match Gemfile.lock
    • 62935163 - Remove 'namespaces_cache_first_auto_devops_config' feature flag
    • b95a9f1d - Change the created add date of the security scan
    • 2d287683 - Contribution Analytics - Deprecate seg control
    • 6e9bea3a - Fix Emoji picker button background in highlighted comment
    • f4df6217 - Hide edit commit message when merging
    • 3b31d6f0 - Add designs migration to GitLab Project Migration
    • 184061c0 - Fix merge request overview tab grid template size
    • b8cafa12 - Rake task to bump CI tables sequences
    • 24c98258 - Add WorkItemUpdateTask mutation to GraphQL API
    • 9c4b823f - Adjust spacing in form group
    • 44da4524 - Apply review feedback for codeowners task
    • 7794ffed - Drop temporary index not needed anymore
    • 38c11ff3 - Add WorkItem description widget to GraphQL API
    • 01c7df1b - Remove Backup::Manager.repositories_storages
    • 28ad9885 - Add backup option to filter for specific projects
    • a38b0e1c - Add remark-gfm dependency
    • a66482af - Support Strikethrough in remark deserializer
    • cbc1575c - Fix GLFM specs for strikethrough
    • 6c975872 - Migrate jquery selectors in project_new.js
    • 203769ce - Merge branch 'ek-remove-jquery-from-new-project-page' into 'master'
    • 10c429ac - Merge branch 'remove-modal-ok-and-modal-cancel-slots-usage' into 'master'
    • c4624422 - Improve Batched Background Migration documentation
    • ada85ab8 - Merge branch '359858-batched-background-migration-documentation-strategies' into 'master'
    • 739f168a - Document the new `namespace` feature flag actor
    • 88d3b617 - Remove Cluters Schedule update service
    • a18dce3b - Merge branch 'docs/namespace-actor-for-feature-flags' into 'master'
    • 9d7d968a - Bump GitLab database migration version
    • 9f544159 - Merge branch '353554-add-end-event-timestamp-to-stage-records' into 'master'
    • e16131e1 - Switch to require spec_helper
    • b7009a87 - Improve error display for Zentao issue
    • de9d6b1a - Merge branch '363441-fix-broken-master' into 'master'
    • 4752d59f - Add E2E test for fix vulnerability workflow
    • 61dfd40c - Merge branch 'hmuralidhar-fix-vulnerability-workflow' into 'master'
    • 9d12ff48 - Merge branch 'kenneth-migration-helper-shell-hint' into 'master'
    • c39f1f9f - Feat: add password complexity requirements to settings
    • f207dffe - Merge branch 'feature/password_complexity' into 'master'
    • 98c0f4a0 - Merge branch 'make-subscriber-event-store-idempotent' into 'master'
    • 2fbc8293 - Guard clause for no external destinations
    • 0fff797d - Merge branch '357276-dont-enqueue-events-wihout-external-destinations' into 'master'
    • f5ce13ce - Merge branch 'update-grape-logging' into 'master'
    • 9c999145 - Remove duplicated blank line
    • d595bbe9 - Clean up security dashboard layout
    • 217708a1 - Merge branch '356327-rework-security-dashboard-layout' into 'master'
    • cc4cc55f - Update Gitlab Shell version to 14.7.1
    • 387d6140 - Fix licensing language
    • 2ed1c968 - Merge branch 'kpaizee-fix-legacy-license' into 'master'
    • 21a59f17 - Merge branch 'feat/remove-expire-pipelinecache-jobcache-workers' into 'master'
    • c961e56b - Update gitaly to 47335e9fa13
    • 1d7d6dba - Merge branch 'ph/362551/containerAroundMRHeader' into 'master'
    • cf722b0b - Lower session expiry when user is unauthenticated
    • 0f4d4479 - Merge branch 'id-bump-gitlab-shell-14-7-1' into 'master'
    • 6bf2ec8c - Merge branch 'ph/hideEditCommitMessage' into 'master'
    • 03e2fc06 - Merge branch 'release-tools/update-gitaly' into 'master'
    • 8925f7f4 - Merge branch 'dmishunov/se-extension-without-api' into 'master'
    • 0f328289 - Delete unused report_not_configured_operational.vue and its test
    • bcfd8c4a - Update MR widget styling
    • 19230cf2 - Merge branch 'lower-session-ttl-for-oauth-controller' into 'master'
    • f0bf0487 - Header add focus ring to more elements
    • acaa8324 - Merge branch 'add-prepend-to-devise-failure' into 'master'
    • 0fb5cb61 - Sync only changed attributes on project and project namespace
    • 51dc3ec2 - Update gitaly to ac989862106
    • a39a367a - GraphQL: Add maintenance_note_html field
    • e7383472 - Merge branch 'database-dictionary-audit-for-release-release' into 'master'
    • 914db780 - Prepare async index to for Ci::JobArtifact
    • 6ed73615 - Merge branch '362321-rake-task-to-bump-ci-tables-sequences' into 'master'
    • 4b5736b8 - Merge branch 'rz-schedule-purging-stale-security-scans-spec-pg11' into 'master'
    • 32b7e2e5 - Merge branch 'migrate-add-approval-rule-button' into 'master'
    • e2dda938 - Make `ci_owned_runners_*` FF on by default
    • 28e4b23f - Merge branch '361641-comments-emoji-picker-bg-fix' into 'master'
    • 07ba3784 - Merge branch '362282-update-task-mutation' into 'master'
    • 900419b4 - Merge branch 'dblessing_remove_group_projects_api_preload_groups_ff' into 'master'
    • 32652708 - Merge branch '362594-update-mr-widget-styling' into 'master'
    • 485ef22e - Merge branch '25607-issue-popovers' into 'master'
    • 1d92a78f - Remove `ci_owned_runners_cross_joins_fix` feature flag
    • 0fb1c43b - Fix typo in templates doc
    • a2eafa31 - Merge branch 'bbodenmiller-master-patch-34778' into 'master'
    • 479de3c5 - Merge branch 'release-tools/update-gitaly' into 'master'
    • efb51b11 - Improve performance of namespace existence lookup
    • 741537d2 - Merge branch 'rz-take-to-limit-aborted-repository' into 'master'
    • 960e1830 - Merge branch '361641-header-elements-focus' into 'master'
    • 2684b0af - Merge branch 'migrate-lock-sidebar-button' into 'master'
    • a1cecee1 - Merge branch 'tor/maintenance/pajamas-conversion/project-settings-cicd' into 'master'
    • c6281a66 - Merge branch 'migrate-mermaid-limit-buttons' into 'master'
    • 7779cde3 - Merge branch 'ph/fixMrSidebarGridSize' into 'master'
    • 27ba283b - Lazy init for popovers
    • 9355f894 - Extract user popover delay into a constant
    • 21c6b79a - Use runOnlyPendingTimers instead of promises
    • e38954b6 - Avoid flashing for cached user popovers
    • 51dcf348 - Remove extra Promise from popover init
    • 5fb6e3ad - Fix UsersCache cached values clobbering
    • 1c2f134c - Remove unnecessary Promises in popover tests
    • 95765828 - Removes the configure later button
    • 5075d43a - Merge branch 'remove-configure-later-button' into 'master'
    • d722d1df - Update supported ZenTao versions
    • ee4ef0a2 - Merge branch 'update_zentao_versions' into 'master'
    • 0630f0d4 - Merge branch '361821-improve-performance-of-namespaces-namespace-exists-api-endpoint' into 'master'
    • 844e1f4f - Fix even more vale warnings
    • 05727c86 - Merge branch 'docs/fix-more-vale-warnings-300-left' into 'master'
    • 195ddaf0 - Merge branch 'remove-ff-sort-projects-in-usage-quotas' into 'master'
    • 98cf3d72 - Migrates the clear cluster cache button
    • 321752ce - Add details about a limitation with test coverage
    • acd9baff - Added mocked assignees to work item
    • 06afb8b8 - Merge branch '334810-add-placeholder-assignees-query' into 'master'
    • 2fa81ac9 - Migrates the upload file button for secure files
    • 9f21a701 - Fix more vale SubstitutionWarning
    • 0830f8db - Code review feedback
    • 62e5414f - Merge branch 'make-ci_owned_runners-on-by-default' into 'master'
    • c4f6125e - Add CRM filtered search tokens on group/project issues page
    • fc273492 - Merge branch '362410-add-crm-filtered-search-tokens' into 'master'
    • aa1c43f0 - Add sum operation to database metrics
    • 8e480a49 - Add example request to match select response
    • fd437e98 - Merge branch 'docs-bcarranza-generic-package-select' into 'master'
    • 3cc97198 - Merge branch 'pedropombeiro/363308/add-html-field' into 'master'
    • 76fd8af9 - Remove unused function argument
    • c9b29f3c - Merge branch 'feat/remove-dast-site-validation-worker' into 'master'
    • 84c7e934 - Update utilisation warning banner
    • dd91f523 - Merge branch 'fneill-update-changes-to-free-tier-projects-warning' into 'master'
    • 3acaa0e4 - Add upstream pipeline attributes in pipeline hooks
    • 22f3dd86 - Move `cadence` under the `starboard` field.
    • c3f8aeb0 - Merge branch 'bwill/fix-cadence-docs' into 'master'
    • d9bd8ce6 - Merge branch 'feat/remove-md5-go' into 'master'
    • b00c16e7 - Follow up refactor variable inheritance shared context
    • b409d464 - Merge branch 'follow-up-refactor-variable-inheritance-shared-context' into 'master'
    • 05ac86dd - Refactor status-box css classes
    • 5e63222c - Merge branch 'cngo-refactor-status-box-classes' into 'master'
    • e66278ba - Merge branch 'cablett-bump-migration-version' into 'master'
    • 8db33e1c - Preload commits markdown cache for CommitsController
    • 3278fce7 - Fix pending members view
    • 2ca9235d - Remove btn-link styles from buttons.scss
    • d18f8ebd - Merge branch '362686-remove-btn-link-styles-from-buttons-scss' into 'master'
    • beffb685 - Fix project packages and registries menu active state
    • cf4f2543 - Merge branch '334846-rename-project-services-controller' into 'master'
    • 78018b60 - Remove RepositoryPushAuditEventWorker
    • de550305 - Adds specs for Regex.sep_by_1
    • d92f8561 - Merge branch 'ajk-test-regex-sep-by-1' into 'master'
    • acd7101a - Merge branch 'slashmanov/lazy-popovers-v2' into 'master'
    • 2a392ab9 - Merge branch 'xanf-fix-next-tick' into 'master'
    • 1caacaca - Clarify runner API changes
    • 9a6f4c48 - Merge branch 'selhorn-clarify-api-changes-runner' into 'master'
    • 26d44849 - Fix incorrect feature flag check
    • 280fe918 - Merge branch '332552-add-sum-operation-to-databasemetric' into 'master'
    • 87a1ef08 - Merge branch 'pipeline_hooks_add_upstream_pipeline_attrs' into 'master'
    • 982dccde - Merge branch '348104-deprecate-date_selector.vue' into 'master'
    • 285c14d5 - Fix difference of storage used in UI
    • 103aba12 - Merge branch '362924-fix-storage-used-difference' into 'master'
    • 267d1f7b - Merge branch 'georgekoltsov/bulk-import-designs-repository' into 'master'
    • 5ea886c4 - Merge branch '360947-preserve-strikethrough-content-editor' into 'master'
    • e658d48b - Merge branch 'nd/fix-pending-members-view' into 'master'
    • fb0f9019 - Migrate above size limit alert to Pajamas ViewComponent
    • c9ea8580 - Refine mini pipeline graph states
    • 66b69bf1 - Merge branch '353980-refine-mpg-button-states' into 'master'
    • f2269d89 - Migrate remove cluster buttons
    • d185a775 - Merge branch 'migrate-remove-cluster-interaction' into 'master'
    • 10319a91 - Cleanup Vulnerability Report store
    • bc214e47 - Cleanup dashboard type logic
    • a21b6f23 - Rename store factory import
    • e916dbc6 - Merge branch 'doc/vale-warnings-yet-again' into 'master'
    • f0a6873c - Announce on which DB migration is run
    • 04bc0637 - Merge branch 'announce-migrations' into 'master'
    • 0ef5c769 - Merge branch 'migrate-clear-cluster-cache' into 'master'
    • 60767b5a - Merge branch...
    • 7c8cd8cb - Move custom VSA dropdown to left of screen
    • e43c9a34 - Merge branch '349677-clearer-labelling-for-custom-vsa-dropdown' into 'master'
    • 8e610256 - Merge branch...
    • fe9a66ca - Replace more http links with the https counterpart
    • d3ca9d72 - Merge branch 'fix/improve_error_display_with_zentao_bad_request' into 'master'
    • 92c9c17b - Migrate storage limit alert to Pajamas
    • 2fe7794c - Merge branch '362556-delete-report-not-configured-operational' into 'master'
    • 8a28f526 - Merge branch 'dblessing_remove_namespaces_cache_first_auto_devops_config_ff' into 'master'
    • 14439d08 - Merge branch 'codeowners-rake-improvements' into 'master'
    • 3c3ee799 - Merge branch 'sd-store-cleanup' into 'master'
    • 258bb660 - Add example of creating a table using the 2.0 migration
    • 8ed4e6ae - Merge branch 'bwill/add-create-table-example' into 'master'
    • 3212bd02 - Merge branch '325408-migrate-storage-limit-alert' into 'master'
    • 98a009e2 - Remove the overflow: hidden from MR widgets
    • 78015f62 - Merge branch '363515-styles-of-pipeline-merge-request-widget-broken' into 'master'
    • d369d94c - Clean up vulnerabilities over time chart and improve tests
    • 6ea40b2e - Merge branch '356327-fix-vulnerabilities-over-time-tests' into 'master'
    • 2792c938 - Remove omniauth_initializer_fullhost_proc FF
    • 093e2cc9 - Add registry migration Guard dynamic pre import timeout
    • 7fb39cbc - Merge branch '363048-guard-worker-dynamic-pre-import-timeout' into 'master'
    • 70d34cd9 - Emphasize that SaaS runners are available by default
    • a9f2b7f1 - Merge branch 'DarrenEastman-master-patch-53608' into 'master'
    • 7ab42486 - Remove content from FAQ and distribute to other locations
    • 5d73c881 - Merge branch '359345-add-db-audit' into 'master'
    • 19a84f7a - Reload to see merge button in test
    • 6503dd72 - Link info about group level settings and project pages
    • 876b22bc - Merge branch 'fneill-add-crosslink-between-group-and-project-pages' into 'master'
    • 5d363b86 - Merge branch '358998-add-type-to-issue-links-internal-api' into 'master'
    • 12222f02 - Merge branch 'fix-project-packages-and-registries-menu' into 'master'
    • e683bad5 - Merge branch 'sync-project-and-project-namespace-more-aggresivelly' into 'master'
    • 3c067149 - Small api docs fix
    • e7f899b1 - Introduce work_items_hierarchy feature flag
    • fdd2c70d - Merge branch 'add_protected_tag_cache' into 'master'
    • 1c1a51f3 - Merge branch 'cablett-api-docs-tweak' into 'master'
    • a8f4deaf - Resolve "Improve coverage regex pytest-cov (Python)"
    • aa42e52c - Merge branch '362234-Improve-coverage-regex-pytest-cov' into 'master'
    • 056713b8 - Merge branch 'docs/more-https-links' into 'master'
    • 8ee2fbf6 - Removed extra text after save
    • 53dc6371 - Merge branch 'selhorn-save-extra-words' into 'master'
    • e2ffdd49 - Add secure terminology for package type/manager
    • 3d24e718 - Merge branch 'document-package-managers-and-types' into 'master'
    • d621c36c - Remove FF ci_trigger_forward_variables
    • f55a71d1 - Merge branch '355572-remove-ci_trigger_forward_variables' into 'master'
    • e8df49d0 - Doc | Add Praefect metric gitaly_praefect_connections_total to doc
    • 54810174 - Merge branch 'psureshbabu-master-patch-24928' into 'master'
    • 4a90bdaf - Merge branch 'cleanup_unused_issue_workers' into 'master'
    • 0dda9e8b - Introduce stub_method for mocking instance methods
    • 166145bb - Merge branch 'sarnold-use-stub-method-instead-of-mocks' into 'master'
    • 23bd9b37 - Merge branch 'philipcunningham-fix-dast-site-token-generation-362992' into 'master'
    • c4428076 - Adding a couple of Google workspace attributes
    • 08d4adfc - Merge branch 'asmaa.hassan-master-patch-53347' into 'master'
    • 594dc826 - Consolidate gitlab symlinking logic
    • d64f8339 - Merge branch 'ml-reload-to-see-merge-button' into 'master'
    • 6ffad549 - Dequarantine end-to-end test
    • 27aa6c2e - Merge branch 'crossner90-master-patch-27066' into 'master'
    • 18a03c93 - Merge branch '362852-hierarchy-widget-ff' into 'master'
    • d1d7bc44 - Update gitaly to a6c5964bb45
    • 886f0166 - Enforce `Migration[2.0]` to make all migrations decomposition supported
    • 64d1c41e - Merge branch 'enforce-migration-2-0' into 'master'
    • 68138c67 - Update Rubocop namespaced_class rule
    • ca3ffb7c - Merge branch '334809-description-widget-resolver' into 'master'
    • 8929651c - Merge branch 'eread/distribute-gitaly-gitaly-cluster-faq-content' into 'master'
    • d93813f5 - Merge branch 'release-tools/update-gitaly' into 'master'
    • fc1e7e74 - Merge branch 'migrate-upload-secure-file' into 'master'
    • 5d6cb118 - Delete vue_issues_list feature flag
    • e72fa9dc - Merge branch 'cngo-delete-vue-issues-list-feature-flag' into 'master'
    • 49343f37 - Merge branch 'remove-unused-eks-cluster-actions' into 'master'
    • d508db10 - Merge branch 'remove-ci_owned_runners_cross_joins_fix' into 'master'
    • 8b1b0cf2 - Migrate admin emails to Pajamas ViewComponent
    • 2980e020 - Merge branch 'preload_markdown_cache_for_commits_controller' into 'master'
    • f9c70170 - Mention certificate_based_clusters feature flag
    • 04e9828c - Update the uploads guide feature bucket details
    • fad22c25 - Merge branch '10io-update-upload-docs' into 'master'
    • f3cf9f06 - Rearrange user popover content for better overview
    • ace53db3 - Merge branch 'ph/fixFeatureFlagCheck' into 'master'
    • f43312b0 - Change order of displayed years in CI minutes app
    • fcb1e05b - Merge branch 'jivanvl-change-order-years-ci-minutes' into 'master'
    • 9806e9bc - Remove updated_mr_header feature flag
    • 0cdf15cd - Merge branch '767-fix-upstream-callouts-test' into 'master'
    • 9d35dd72 - Merge branch 'feat/remove-pushauditeventworker' into 'master'
    • 75b10f30 - Migrate p_terraform_state_api_unique to Snowplow
    • 93c0294c - Merge branch 'migrate_p_terraform_state_api_unique_users_to_snowplow' into 'master'
    • c8fa4312 - Merge branch '361986-rearrange-user-popover-layout' into 'master'
    • 6450dfee - Add more logging instruments to CI pipeline creation
    • c984cd8d - Fix more vale warnings
    • c4c596c2 - Migrates the CLI Commands dropdown for containers
    • 34e56c4c - Fix Service Ping payload hash key shadowing
    • 7207773b - Remove no longer helpful doc topic
    • b1f0ef03 - Merge branch 'morefice/prepare-async-index-job-artifacts' into 'master'
    • b6aea222 - Migrates the revoke oauth button for GCP
    • df5f5ae2 - Merge branch 'update-authowners-normalize-patterns' into 'master'
    • 47f4a06d - Migrate project new tag alert to Pajamas ViewComponent
    • 0c869994 - Fix Service Ping report specs and add mixed type spec
    • 17524b6c - Update doc/user/clusters/agent/index.md
    • 9dc66dd1 - Merge branch 'add-more-logging-instruments-to-pipeline-creation' into 'master'
    • ab2e41f1 - Add note about rate limiting architecture WG to dev docs
    • 188d97ee - Allow text nodes inside the root document
    • e91fd2fc - Merge branch 'docs/gb/add-reference-to-rate-limiting-wg' into 'master'
    • 51e2047e - Include inherited owners in User#solo_owned_groups
    • 415c7ca8 - Merge branch...
    • 67418f22 - Merge branch 'migrate-revoke-google-oauth' into 'master'
    • 6cc8dd47 - Merge branch...
    • c6164423 - Implement new PAT API endpoint 'id'
    • 3bf6e616 - Merge branch 'feature/#362239_PAT_API_endpoint_id' into 'master'
    • 401685c8 - Merge branch 'katrinleinweber-master-patch-52927' into 'master'
    • 8b8b77e1 - Merge branch 'ph/removeUpdatedMRHeaderFeatureFlag' into 'master'
    • 7dc2ba2c - Merge branch 'fix-direct-text-nodes-in-document' into 'master'
    • 202fe3fa - Change breakpoints for new merge request sidebar
    • d047930b - Merge branch 'psk-fix-service-ping-key-shadowing' into 'master'
    • 398cbe9e - Fix Geo QA CI job log artifacts replication tests
    • 460e3722 - Merge branch...
    • c86ffa7e - Add design review by Verify maintainers
    • c13b5bfe - Merge branch 'alberts-add-verify-maintainers' into 'master'
    • 6f0604a1 - Document haml reviewers responsible
    • 650779a5 - Fix scan-execution-policies.md policies rule
    • 352b9e75 - Merge branch 'mparuszewski-master-patch-46060' into 'master'
    • 11843b10 - Adding new Civo cluster integration
    • 78bf49c8 - Merge branch 'saiyam1-master-patch-29736' into 'master'
    • cd714a91 - Improve Vulnerability Page details
    • 8bb4c8d6 - Merge branch 'russell/improve-vuln-page-details' into 'master'
    • fcd05d7b - Merge branch 'nagyv-gitlab-master-patch-77116' into 'master'
    • 10bb9dd3 - Merge branch 'docs/vale-warnings-more' into 'master'
    • 4381ce7c - Merge branch 'docs-code-coverage-manual-jobs' into 'master'
    • 82e357f6 - Remove container_security_policy_selection related code
    • 895a33c9 - Merge branch '358987-cleanup-feature-flag' into 'master'
    • 5824aed6 - Fix Product Name of DataGrip and Codeblock Language
    • 3830bb94 - Merge branch 'migrate-cli-commands-container' into 'master'
    • dcb6c952 - Migrate push rules edit alert to Pajamas ViewComponent
    • 9a397ee8 - Remove section about explicit AuthenticationType
    • ceff3fb8 - Merge branch 'docs-revert-authtype-deprecation' into 'master'
    • 7afa91b8 - Merge branch 'doc/database-debugging-fix' into 'master'
    • 3d4f29d2 - Add trivy container scanning support for Alpine
    • 5a45a7e0 - Merge branch 'cat-remove-omniauth-initializer-proc-ff' into 'master'
    • 4741b245 - Clarify security approval MR rules
    • 2ee044af - Merge branch 'sam-clarify-security-approval-mr-rules' into 'master'
    • f557166a - Merge branch 'sam.white-master-patch-78640' into 'master'
    • 6024fedc - Migrate button in suggest popover
    • e6094b87 - Merge branch 'migrate-button-suggest-popover' into 'master'
    • cc8b1f8e - Added civo to list of clusters
    • fce909fb - Merge branch...
    • 4b2074a9 - Merge branch 'sselhorn-master-patch-42626' into 'master'
    • 91348d30 - Migrate button to confirm users email
    • c4eb52c6 - Update flaky deployment entity spec
    • 638394e5 - Merge branch '356420-update-flaky-deployment-entity-spec' into 'master'
    • 858ba54f - Merge branch 'caw-update-namespaced-class-rule' into 'master'
    • b6f887f6 - Merge branch 'migrate-confirm-email-button' into 'master'
    • df68b457 - Migrates the save changes button for new geo site
    • a72840c6 - Fix more vale substitution warnings
    • ac464fc7 - Add VulnerabilityStateTransition model
    • 4b769c4a - Merge branch 'mc_rocha-create-vulnerabilities-state-transition-model-325700' into 'master'
    • 78d5351f - Merge branch...
    • 166caa86 - Shift words to lower-case
    • d6f28c73 - Merge branch 'docs/vale-warnings-more-pt2' into 'master'
    • d5d845bb - Merge branch 'cat-fix-qa-geo-ci-artifacts-specs' into 'master'
    • 0e25d680 - Merge branch 'backup_projects' into 'master'
    • f88c5dbe - Fix terraform remote state datasource documentation
    • 1795d0be - Merge branch 'fix/terraform-datasource-documentation' into 'master'
    • 11f204a0 - Move 2 E2E specs to EE
    • c5e9aa7f - Merge branch 'qe-move-specs-to-ee-needs-project' into 'master'
    • 9f4455bd - Replace jQuery in projects/project_visibility.js file
    • 39c69268 - Update dependency list page subheader
    • 9fa4707f - Migrates try out pipeline button in mr widget
    • 9f382f3d - Merge branch 'migrate-try-out-pipelines' into 'master'
    • 631c2c82 - Merge branch 'fix/remove-jquery-362995' into 'master'
    • 3738260e - Introduce source versions for BulkImport trackers configuration
    • 1ecb3399 - Merge branch 'rodrigo/358743-add-minimum-source-version' into 'master'
    • c2c6ce0b - Merge branch 'sam-add-sbom-subheader' into 'master'
    • 261012b5 - Merge branch 'alberts-remove-codequality-merge-request-widget-entity' into 'master'
    • 4a05a7a8 - Merge branch 'ph/363413/changedMovedSidebarBreakpoints' into 'master'
    • 04c3443a - Remove gitaly_replace_wiki_create_page flag
    • 5d8fa525 - Merge branch 'caw-remove-gitaly_replace_wiki_create_page-flag' into 'master'
    • e6df1842 - Merge branch 'migrate-geo-add-site' into 'master'
    • a30ed390 - Update BulkImports to handle empty relation status responses
    • 3c9803ca - Merge branch 'rodrigo/358743-fix-race-condition-in-bulk-import' into 'master'
    • 3d2442b7 - Migrate button to view issue for error
    • 6425aed6 - Fix PG version mentioned for package upgrades
    • 2642d7f7 - Migrate jquery selectors in project import gitlab project js
    • be49c9c5 - Docs: How to avoid Gitaly /tmp issue on 14.10
    • 290f0dab - Merge branch '362993-replace-jquery-for-project-import-gitlab-project' into 'master'
    • 6ee7752e - Merge branch 'migrate-view-issue-error' into 'master'
    • 2f8482f5 - Merge branch 'msj-remove-milestones-sprints' into 'master'
    • 9afabe8b - Revert "Merge branch 'stop-automatic-retries-smoke-reliable' into 'master'"
    • 158d4c07 - Merge branch 'fix-pg-version' into 'master'
    • fce5f4b4 - Fix broken external links in docs pt 1
    • 9e2f6b54 - Merge branch 'msj-broken-links-may' into 'master'
    • 1172493d - Replace Enablement stage with Systems in docs metadata
    • 4a4d5eff - Merge branch '362454-remove-clusters-schedule-update-service' into 'master'
    • 314749be - [Docs] Use https instead of protocol-relative URL
    • 7d33d259 - Merge branch 'docs-jayo-add-protocol-to-cdn-host' into 'master'
    • ed6e6002 - Add handbook reference for maximum import size
    • 65245778 - Merge branch 'wortschi-master-patch-56014' into 'master'
    • 8d4aabc0 - Merge branch 'revert-483874a6' into 'master'
    • ac321a28 - Merge branch 'axil-split-enablement-stage-metadata' into 'master'
    • 1cf35363 - Merge branch 'allison.browne-document-haml-backend-and-frontend' into 'master'
    • 7453cccb - doc: Add clarification on use of when:never/always
    • 6ec21399 - Merge branch 'ci-when-docs-update' into 'master'
    • ef551e29 - Migrates the example in docs from success
    • 818d7ca3 - Merge branch 'migrate-vue-docs-success' into 'master'
    • 0e005422 - Merge branch 'docs-clarify-noatime-tmp-fix' into 'master'
    • 98b88986 - Merge branch...
    • 1ffc6dd0 - Add verification_disabled state
    • 6b7a110d - Geo: Mark object stored as verification disabled
    • 01d85527 - Exclude verification disabled from counts
    • 749b77fa - Patch ActiveRecord::Generators::Migration#configured_migrated_path
    • d1ba566b - Merge branch 'mk/scope-verification-properly' into 'master'
    • 3e9d2c79 - Merge branch 'da-patch-migration-generator' into 'master'
    • d0328142 - Add methods to retrieve report builds from descendants
    • a0ae2e82 - Add feature flag ci_child_pipeline_coverage_reports
    • daa5db77 - Include child pipeline into `can_generate_coverage_reports?`
    • 0c87af69 - Include child pipelines into coverage report
    • 3b7366fe - Extract coverage report out of pipeline and build

    Compare with previous version

  • Ghost User
  • Albert added 1 commit

    added 1 commit

    • 9f66a363 - Extract coverage report out of pipeline and build

    Compare with previous version

  • Albert added 5 commits

    added 5 commits

    • daa287fe - 1 commit from branch 363301-use-child-pipeline-job-artifacts-for-mr-coverage-report
    • bc73732e - Add feature flag ci_child_pipeline_coverage_reports
    • 7c95bdaa - Include child pipeline into `can_generate_coverage_reports?`
    • 1a087482 - Include child pipelines into coverage report
    • 24d85d43 - Extract coverage report out of pipeline and build

    Compare with previous version

  • Albert
  • Albert added 1 commit

    added 1 commit

    • 93c2501d - Add project actor to feature flag

    Compare with previous version

  • Albert added 1 commit

    added 1 commit

    • 0bd61f07 - Remove build.project eager load

    Compare with previous version

  • Albert marked this merge request as ready

    marked this merge request as ready

  • Albert changed the description

    changed the description

  • Albert
  • Albert requested review from @iamricecake

    requested review from @iamricecake

  • Author Contributor

    @iamricecake Could you review please?

  • Albert changed the description

    changed the description

  • Erick Bajao
  • Erick Bajao
  • Thanks @alberts-gitlab, looking good! Left some comments for clarification and consideration. Back to you :ping_pong:

  • Erick Bajao removed review request for @iamricecake

    removed review request for @iamricecake

  • Albert added 237 commits

    added 237 commits

    • 0bd61f07...0eb28ab1 - 231 commits from branch 363301-use-child-pipeline-job-artifacts-for-mr-coverage-report
    • b3d527c4 - Add feature flag ci_child_pipeline_coverage_reports
    • b80cec8e - Include child pipeline into `can_generate_coverage_reports?`
    • 96a03f7a - Include child pipelines into coverage report
    • 389502e6 - Extract coverage report out of pipeline and build
    • 5fd8df5c - Add project actor to feature flag
    • 0e8e8707 - Remove build.project eager load

    Compare with previous version

  • Albert added 2 commits

    added 2 commits

    • 3e575982 - Add a separate method to check if pipeline hierarchy is complete
    • 1958fb97 - Rename #data to #report

    Compare with previous version

  • Author Contributor

    @iamricecake I updated the MR to separate the complete? check. I did not move pipeline.has_coverage_reports? into the CoverageReportGenerator, as it still seems to fit well within CoverageReportService.

  • Albert requested review from @iamricecake

    requested review from @iamricecake

  • Erick Bajao
  • Erick Bajao
  • Erick Bajao approved this merge request

    approved this merge request

    • Resolved by Albert

      @alberts-gitlab just one minor issue left about changing the CoverageReports to a singular CoverageReport. Other comments I left are more for discussion and if ever, follow-ups. I will also give the approval now, feel free to have it reviewed by a maintainer once the minor issue has been addressed.

  • Erick Bajao removed review request for @iamricecake

    removed review request for @iamricecake

  • :wave: @iamricecake, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Albert added 562 commits

    added 562 commits

    • 1958fb97...368e48d7 - 554 commits from branch 363301-use-child-pipeline-job-artifacts-for-mr-coverage-report
    • cc558cb4 - Add feature flag ci_child_pipeline_coverage_reports
    • e2cfa3de - Include child pipeline into `can_generate_coverage_reports?`
    • f7c14164 - Include child pipelines into coverage report
    • ced7e364 - Extract coverage report out of pipeline and build
    • 1bfa1d54 - Add project actor to feature flag
    • 5fc99e47 - Remove build.project eager load
    • 621f7b12 - Add a separate method to check if pipeline hierarchy is complete
    • a3c34546 - Rename #data to #report

    Compare with previous version

  • Albert mentioned in merge request !89099 (merged)

    mentioned in merge request !89099 (merged)

  • Albert mentioned in issue #364165

    mentioned in issue #364165

  • Albert mentioned in issue #364166 (closed)

    mentioned in issue #364166 (closed)

  • Albert changed target branch from 363301-use-child-pipeline-job-artifacts-for-mr-coverage-report to master

    changed target branch from 363301-use-child-pipeline-job-artifacts-for-mr-coverage-report to master

  • Albert changed the description

    changed the description

  • Albert marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Albert mentioned in epic &6859 (closed)

    mentioned in epic &6859 (closed)

  • Albert requested review from @fabiopitino

    requested review from @fabiopitino

  • Albert added 379 commits

    added 379 commits

    • a3c34546...12cc4ea4 - 370 commits from branch master
    • aee21fc1 - Add methods to retrieve report builds from descendants
    • 1ee34d61 - Add feature flag ci_child_pipeline_coverage_reports
    • 400e8339 - Include child pipeline into `can_generate_coverage_reports?`
    • e8b4bf18 - Include child pipelines into coverage report
    • 5228b415 - Extract coverage report out of pipeline and build
    • 2360e3e5 - Add project actor to feature flag
    • c3143fbd - Remove build.project eager load
    • 9b77f08b - Add a separate method to check if pipeline hierarchy is complete
    • 23e3b316 - Rename #data to #report

    Compare with previous version

  • Fabio Pitino
  • Fabio Pitino
  • Fabio Pitino
  • Fabio Pitino removed review request for @fabiopitino

    removed review request for @fabiopitino

  • Albert added 2 commits

    added 2 commits

    Compare with previous version

  • Albert added 644 commits

    added 644 commits

    • a7905d9e...ed80731e - 633 commits from branch master
    • 6f01cdb4 - Add methods to retrieve report builds from descendants
    • eda86f21 - Add feature flag ci_child_pipeline_coverage_reports
    • ea854f43 - Include child pipeline into `can_generate_coverage_reports?`
    • f798804c - Include child pipelines into coverage report
    • c868b961 - Extract coverage report out of pipeline and build
    • f33b8bc8 - Add project actor to feature flag
    • 2f150ee5 - Remove build.project eager load
    • f4fab096 - Add a separate method to check if pipeline hierarchy is complete
    • d908c6e0 - Rename #data to #report
    • 2aec71eb - Remove unneeded `latest`
    • f25e5505 - Use singular coverage_report

    Compare with previous version

  • Albert added 2 commits

    added 2 commits

    • 6429909e - Remove the need to check if can generate coverage report
    • 4de1406c - Remove unused method has_reports_in_self_and_descendants?

    Compare with previous version

  • Albert added 1 commit

    added 1 commit

    Compare with previous version

  • Albert
  • Author Contributor

    @fabiopitino Could you take a look again please? Thanks for the pointer on parent - child pipeline strategy. I think this is in a much better state now.

  • Albert requested review from @fabiopitino

    requested review from @fabiopitino

  • Albert added 1 commit

    added 1 commit

    • b072612e - Add documentation on child pipeline coverage report

    Compare with previous version

  • mentioned in issue #364823 (closed)

  • Fabio Pitino
  • Fabio Pitino
  • Fabio Pitino
  • Fabio Pitino
  • Fabio Pitino removed review request for @fabiopitino

    removed review request for @fabiopitino

  • Albert requested review from @fabiopitino

    requested review from @fabiopitino

  • Albert added 460 commits

    added 460 commits

    • b072612e...f8c1f58a - 446 commits from branch master
    • 52fb1a37 - Add methods to retrieve report builds from descendants
    • 23b35017 - Add feature flag ci_child_pipeline_coverage_reports
    • 50100b17 - Include child pipeline into `can_generate_coverage_reports?`
    • e9f0f482 - Include child pipelines into coverage report
    • 169a3dd0 - Extract coverage report out of pipeline and build
    • 1458896e - Add project actor to feature flag
    • c92730b6 - Remove build.project eager load
    • bc295698 - Add a separate method to check if pipeline hierarchy is complete
    • 5c6c0a1b - Rename #data to #report
    • 77344e16 - Remove unneeded `latest`
    • 73a69876 - Use singular coverage_report
    • fcca86f6 - Remove the need to check if can generate coverage report
    • 0a8fb844 - Remove unused methods
    • 6546e574 - Add documentation on child pipeline coverage report

    Compare with previous version

  • mentioned in issue #365144 (closed)

  • Fabio Pitino approved this merge request

    approved this merge request

  • @alberts-gitlab LGTM :tada: I've extracted the follow-ups into #365144 (closed)

  • Fabio Pitino enabled an automatic merge when the pipeline for 4a3ae813 succeeds

    enabled an automatic merge when the pipeline for 4a3ae813 succeeds

  • merged

  • Fabio Pitino mentioned in commit 6bc33351

    mentioned in commit 6bc33351

  • added workflowstaging label and removed workflowcanary label

  • Albert mentioned in issue #363301 (closed)

    mentioned in issue #363301 (closed)

  • Albert mentioned in merge request !89950 (merged)

    mentioned in merge request !89950 (merged)

  • Albert mentioned in merge request !76612 (merged)

    mentioned in merge request !76612 (merged)

  • Albert mentioned in epic &8598

    mentioned in epic &8598

  • mentioned in issue #386496 (closed)

  • Please register or sign in to reply
    Loading