Skip to content

Add prototype of codequality inline-findings

Jannik Lehmann requested to merge jnnkl-codequality-findings-diff-inline into master

What does this MR do and why?

This MR is meant to solve #362526 (closed). It refactors the Body of the inline CodeQuality Findings to display them inline below the row component, rather than in a popover.

The changes are hidden behind the :refactor_code_quality_inline_findings

The flag will be toggled on as soon as the other Issues on the epic are resolved.

Screenshots or screen recordings

Demo:

before after
2022-06-03_10-22-59 2022-06-07_14-01-46

How to set up and validate locally

  1. Feature.enable(:refactor_code_quality_inline_findings)
  2. Clone this project in your GDK https://gitlab.com/jannik_lehmann/code-quality-test
  3. Recreate this MR or open up a MR with code Quality Issues yourself
  4. go visit the changes tab on the MR and hover/click the CodeQuality indicator to see the changes in action

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports