Update path navigation to go to parent policies
What does this MR do and why?
Update path navigation to go to parent policies
- previously the path navigated the user to the parent project
- now it navigates the user to the parent's policies
Screenshots or screen recordings
N/A
How to set up and validate locally
- Enable
:group_level_security_policies
feature flag - Upload a GitLab Ultimate license
- Navigate to a group =>
Security & Compliance
=>Policies
and assign a policy project with policies in it (using Update policy project selection for groups (!86981 - merged), but this MR is not dependent on it) - Navigate to a project in that group =>
Security & Compliance
=>Policies
and assign a different policy project with policies in it - Verify the inheritance
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #345321 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @aturinske
- Resolved by Kushal Pandya
@bsandlin can you review this? Thanks
requested review from @bsandlin
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Fernando Arias ( @farias-gl
) (UTC-5, 1 hour ahead of@aturinske
)Peter Hegman ( @peterhegman
) (UTC-7, 1 hour behind@aturinske
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerSuggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @alyubenkov
,@bsandlin
,@sheldonled
,@hmuralidhar
,@ebralitis
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender BotBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1a4f7b3a and f776c1e5
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.46 MB - 0.0 % mainChunk 1.94 MB 1.94 MB - 0.0 %
Note: We do not have exact data for 1a4f7b3a. So we have used data from: 6ee7752e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for f776c1e5expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Plan | 41 | 0 | 1 | 41 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Manage | 36 | 0 | 2 | 38 | ❗ | | Create | 23 | 0 | 2 | 23 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 114 | 0 | 9 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
removed [deprecated] Accepting merge requests label
removed review request for @bsandlin
@bsandlin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @kushalpandya
added 280 commits
-
1c8f251a...5d8fa525 - 279 commits from branch
master
- f776c1e5 - Update path navigation to go to parent policies
-
1c8f251a...5d8fa525 - 279 commits from branch
enabled an automatic merge when the pipeline for 716340d5 succeeds
mentioned in commit f94a0386
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-com/www-gitlab-com#13518 (closed)
added releasedpublished label
added releasedcandidate label and removed releasedpublished label