Cleanup «New user/Edit user» forms
What does this MR do and why?
Changes
- Removes unnessessary dividers
- Changes labels to be on top of fields
- Removes background from form actions
Screenshots or screen recordings
Before | After |
---|---|
New user![]() |
New user![]() |
Edit user![]() |
Edit user![]() |
How to set up and validate locally
Go to /admin/users/new
Related to #361641 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @seggenberger
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @reprazent
,@jivanvl
,@psimyn
,@rspeicher
,@mikegreiling
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot3 Warnings ⚠ This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.If needed, you can retry the
🔁 danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Allen Cook ( @acook.gitlab
) (UTC-4, 6 hours behind@seggenberger
)Vasilii Iakliushin ( @vyaklushin
) (UTC+2, same timezone as@seggenberger
)frontend Coung Ngo ( @cngo
) (UTC+1, 1 hour behind@seggenberger
)Miguel Rincon ( @mrincon
) (UTC+2, same timezone as@seggenberger
)UX Michael Fangman ( @mfangman
) (UTC-5, 7 hours behind@seggenberger
)No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
🚫 Dangerassigned to @aregnery
- Resolved by Sascha Eggenberger
@aregnery assigning this to you, as you reviewed all the other form related cleanups
🙂
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
❗ test report for 80724805expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 22 | 0 | 3 | 22 | ❗ | | Manage | 36 | 0 | 2 | 38 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Configure | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 113 | 0 | 10 | 115 | ❗ | +----------------------+--------+--------+---------+-------+--------+
requested review from @aregnery
unassigned @aregnery
mentioned in issue aregnery/aregnery#24 (closed)
- Resolved by Robert Hunt
requested review from @rob.hunt
mentioned in issue #332977 (closed)
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
removed review request for @rob.hunt
requested review from @rob.hunt
added 1582 commits
-
ef8c860d...66f09c1e - 1581 commits from branch
master
- 80724805 - Cleanup New user form
-
ef8c860d...66f09c1e - 1581 commits from branch
mentioned in issue aregnery/aregnery#28 (closed)
mentioned in merge request !89414 (merged)
mentioned in merge request !89417 (merged)
mentioned in merge request !89418 (merged)
mentioned in merge request !89422 (merged)
👋 @rob.hunt
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for c72aa86f succeeds
mentioned in commit 996de451
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
mentioned in issue #361999 (closed)
added workflowproduction label and removed workflowstaging label
added releasedpublished label
mentioned in merge request kubitus-project/kubitus-installer!1153 (merged)
mentioned in issue #366325 (closed)
added releasedcandidate label and removed releasedpublished label
mentioned in issue #346945