Introduce work_items_hierarchy feature flag
What does this MR do and why?
Hides component introduced in !88097 (merged) behind :work_items_hierarchy
feature flag.
Slack conversation for context: https://gitlab.slack.com/archives/C02403NRD40/p1653436766819919?thread_ts=1653436384.678409&cid=C02403NRD40
Screenshots or screen recordings
FF off | FF on |
---|---|
![]() |
![]() |
How to set up and validate locally
-
Enable
work_items
feature flagFeature.enable(:work_items)
-
Visit an issue page, and add a checklist item to description
-
Hover over checklist item, then click 'Convert to task' button on the left
-
Save the work item
-
Click on the newly created work item
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #362852 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @fguibert
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @NikolayS
,@kmann
,@adriel
,@npost
,@rymai
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend John Mason ( @john-mason
) (UTC-4, 14 hours behind@fguibert
)Charlie Ablett ( @cablett
) (UTC+12, 2 hours ahead of@fguibert
)frontend Alper Akgun ( @a_akgun
) (UTC+3, 7 hours behind@fguibert
)Michael Lunøe ( @mlunoe
) (UTC+2, 8 hours behind@fguibert
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e683bad5 and e7f899b1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.46 MB - 0.0 % mainChunk 1.94 MB 1.94 MB - 0.0 %
Note: We do not have exact data for e683bad5. So we have used data from: 7fb39cbc.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for e7f899b1expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 36 | 0 | 2 | 38 | ❗ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | | Create | 23 | 0 | 2 | 23 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 114 | 0 | 9 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
package-and-qa-ff-enabled:
test report for e7f899b1expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 182 | 0 | 12 | 0 | ✅ | | Create | 295 | 1 | 14 | 3 | ❌ | | Configure | 0 | 0 | 6 | 0 | ➖ | | Verify | 76 | 0 | 6 | 5 | ❗ | | Fulfillment | 4 | 0 | 22 | 0 | ✅ | | Plan | 106 | 0 | 0 | 0 | ✅ | | Package | 0 | 0 | 6 | 0 | ➖ | | Secure | 40 | 0 | 4 | 3 | ❗ | | Version sanity check | 0 | 0 | 2 | 0 | ➖ | | Release | 12 | 0 | 0 | 0 | ✅ | | Non-devops | 4 | 0 | 0 | 0 | ✅ | | Protect | 4 | 0 | 0 | 0 | ✅ | +----------------------+--------+--------+---------+-------+--------+ | Total | 723 | 1 | 72 | 11 | ❌ | +----------------------+--------+--------+---------+-------+--------+
package-and-qa-ff-disabled:
test report for e7f899b1expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 296 | 0 | 14 | 7 | ❗ | | Configure | 0 | 0 | 6 | 0 | ➖ | | Manage | 182 | 0 | 12 | 0 | ✅ | | Verify | 76 | 0 | 6 | 4 | ❗ | | Plan | 106 | 0 | 0 | 0 | ✅ | | Package | 0 | 0 | 6 | 0 | ➖ | | Secure | 40 | 0 | 4 | 1 | ❗ | | Release | 12 | 0 | 0 | 0 | ✅ | | Non-devops | 4 | 0 | 0 | 0 | ✅ | | Fulfillment | 4 | 0 | 22 | 0 | ✅ | | Protect | 4 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 2 | 1 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 724 | 0 | 72 | 13 | ❗ | +----------------------+--------+--------+---------+-------+--------+
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
@cngo Could you please review?
requested review from @cngo
- The
gitlab-qa-mirror
downstream pipeline for !88504 (57834304) passed. - The
gitlab-qa-mirror
downstream pipeline for !88504 (57834304) passed. - The
gitlab-qa-mirror
downstream pipeline for !88504 (57834304) passed. - The
gitlab-qa-mirror
downstream pipeline for !88504 (57834304) passed. - The
gitlab-qa-mirror
downstream pipeline for !88504 (e7f899b1) passed. - The
gitlab-qa-mirror
downstream pipeline for !88504 (e7f899b1) failed!
- The
- Resolved by Kushal Pandya
removed review request for @cngo
@cngo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 211 commits
-
57834304...876b22bc - 210 commits from branch
master
- e7f899b1 - Introduce work_items_hierarchy feature flag
-
57834304...876b22bc - 210 commits from branch
requested review from @kushalpandya
@kushalpandya, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
mentioned in commit 18a03c93
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedpublished label
added releasedcandidate label and removed releasedpublished label