Migrate pages domain alert to Pajamas ViewComponent
requested to merge 325379-migrate-to-pajamas-alertcomponent-viewcomponent-in-app-views-projects-pages_domains-show into master
What does this MR do and why?
Migrate pages domain alert to Pajamas ViewComponent
Related to Migrate to Pajamas::AlertComponent ViewComponen... (#325379 - closed)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
Snapshot before
<div class="gl-alert gl-alert-warning">
<div class="container-fluid container-limited">
This domain is not verified. You will need to verify ownership before access is enabled.
</div>
</div>
Snapshot after
<div class="gl-alert gl-alert-warning gl-alert-not-dismissible" role="alert">
<svg class="s16 gl-alert-icon gl-alert-icon-no-title" data-testid="warning-icon"><use href="/assets/icons-f305926186cfc3bb530f27269d545937c385578ba62adb0088d74f0d2d02cb56.svg#warning"></use></svg>
<div class="gl-alert-content" role="alert">
<div class="gl-alert-body">
<div class="container-fluid container-limited">
This domain is not verified. You will need to verify ownership before access is enabled.
</div>
</div>
</div>
</div>
How to set up and validate locally
Setting up pages is quite complicated, but here is the easy hacky to show the alert
- Create a pages domain (it's already unverified) for a project http://gdk.test:3000/testg/testp
bin/rails c
my_project = Project.find_by_full_path('/testg/testp')
PagesDomain.create domain: 'acme.org', project: my_project
2. Go to http://gdk.test:3000/testg/testp/pages/domains/acme.org
## MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
* [x] I have evaluated the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist) for this MR.
Edited by Alper Akgun