Fix pending members view
What does this MR do and why?
The pending members view is part of the groups/usage_quotas page where we try to initialilze the NamespaceStorage Vue application as well.
However, as we don't render the #js-storage-counter-app
element with
the data for the Vue application, initNamespaceStorage
raises an
error.
To fix this, we don't try to initialize the Vue Application and return early (as we do it for the other Vue applications as well).
No changelog because it's behind the feature flag saas_user_caps
.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Stop your gdk
export GITLAB_SIMULATE_SAAS=1
gdk start
bin/rails c
Feature.enable(:saas_user_caps)
ApplicationSetting.first.update(check_namespace_plan: true)
- Go to Admin > Groups. Choose a group and give it a paid plan
- Go to the rails console again
bin/rails c
to set a member to be awaiting, e.g.group = Group.find(ID_OF_YOUR_GROUP) # find your group's ID group.members.last.wait!
- Go to the Group's Usage Quota Page (Group > Settings > Usage Quota)
- You should see the banner "Pending members", click on it, you see the page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Nicolas Dular