Add auditEventsStreamingHeadersDestroy Mutation
What does this MR do and why?
- Adds a new graphQL mutation
auditEventsStreamingHeadersDestroy
to destroy a custom header on a streaming destination.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
- Enable the
streaming_audit_event_headers
feature flag. - Create an Ultimate group.
- Create a streaming destination. (Group -> Security & Compliance -> Audit Events -> Streams)
- Using GraphQL, create a header.
mutation {
auditEventsStreamingHeadersCreate(input: { destinationId: "gid://gitlab/AuditEvents::ExternalAuditEventDestination/ID GOES HERE", key: "X-Foo", value: "bar" }) {
errors
clientMutationId
header {
id
value
key
}
}
}
- Using the returned ID value, delete the same header.
mutation {
auditEventsStreamingHeadersDestroy(input: { headerId: "gid://gitlab/AuditEvents::Streaming::Header/7" }) {
errors
clientMutationId
}
}
- Ensure that the header has been deleted from the database.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #361217 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @mwoolf
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @alexkalderimis
,@eread
,@kerrizor
,@rspeicher
,@dbalexandre
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning 6e25b72b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. If needed, you can retry the
danger-review
job that generated this comment.Documentation review
The following files require a review from a technical writer:
doc/administration/audit_event_streaming.md
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Niko Belokolodov ( @nbelokolodov
) (UTC+8, 7 hours ahead of@mwoolf
)Luke Duncalfe ( @.luke
) (UTC+12, 11 hours ahead of@mwoolf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 3291 commits
-
cfce4f9c...f9da613c - 3283 commits from branch
master
- d28d185e - Create audit stream HTTP header model
- d348ce8d - Add graphql support for audit streaming headers
- 305ff5cc - Custom headers for audit streams
- 84e0e8f8 - Backend reviewer suggestions applied
- 7960eb35 - Database reviewer suggestions applied
- ee3c5cf4 - Database maintainer suggestions
- 147097e1 - Backend maintainer suggestions resolved
- 35aa60fd - Add auditEventsStreamingHeadersDestroy Mutation
Toggle commit list-
cfce4f9c...f9da613c - 3283 commits from branch
added 1 commit
- 844463a1 - Add auditEventsStreamingHeadersDestroy Mutation
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 35aa60fdexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Manage | 36 | 0 | 2 | 37 | 38 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Plan | 48 | 0 | 1 | 45 | 49 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 121 | 0 | 9 | 118 | 130 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
package-and-qa-ff-enabled:
test report for 35aa60fdexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Package | 0 | 0 | 9 | 0 | 9 | ➖ | | Secure | 51 | 0 | 5 | 8 | 56 | ❗ | | Create | 422 | 0 | 18 | 23 | 440 | ❗ | | Manage | 289 | 1 | 11 | 0 | 301 | ❌ | | Plan | 154 | 0 | 3 | 0 | 157 | ✅ | | Verify | 109 | 0 | 7 | 0 | 116 | ✅ | | Configure | 0 | 0 | 9 | 0 | 9 | ➖ | | Fulfillment | 6 | 0 | 30 | 0 | 36 | ✅ | | Product Intelligence | 6 | 0 | 0 | 0 | 6 | ✅ | | Protect | 6 | 0 | 0 | 0 | 6 | ✅ | | Release | 16 | 0 | 0 | 0 | 16 | ✅ | | Version sanity check | 0 | 0 | 3 | 3 | 3 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 1059 | 1 | 95 | 34 | 1155 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
package-and-qa-ff-disabled:
test report for 35aa60fdexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Verify | 120 | 0 | 9 | 0 | 129 | ✅ | | Configure | 0 | 0 | 9 | 0 | 9 | ➖ | | Create | 447 | 0 | 18 | 27 | 465 | ❗ | | Manage | 302 | 1 | 12 | 0 | 315 | ❌ | | Plan | 159 | 0 | 3 | 0 | 162 | ✅ | | Secure | 60 | 0 | 6 | 12 | 66 | ❗ | | Fulfillment | 6 | 0 | 33 | 0 | 39 | ✅ | | Product Intelligence | 6 | 0 | 0 | 0 | 6 | ✅ | | Package | 0 | 0 | 9 | 0 | 9 | ➖ | | Release | 18 | 0 | 0 | 0 | 18 | ✅ | | Version sanity check | 0 | 0 | 3 | 3 | 3 | ➖ | | Protect | 6 | 0 | 0 | 0 | 6 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 1124 | 1 | 102 | 42 | 1227 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Luke Duncalfe
@eread Could you take a look at the small docs addition here please?
requested review from @eread
added 317 commits
-
844463a1...15264fe1 - 316 commits from branch
master
- 3565a28d - Add auditEventsStreamingHeadersDestroy Mutation
-
844463a1...15264fe1 - 316 commits from branch
- Resolved by Huzaifa Iftikhar
- Resolved by Luke Duncalfe
@huzaifaiftikhar1 Could you do the initial backend review of this please?
requested review from @huzaifaiftikhar1
- The
gitlab-qa-mirror
downstream pipeline for !88408 (35aa60fd) failed! - The
gitlab-qa-mirror
downstream pipeline for !88408 (35aa60fd) failed!
- The
- Resolved by Evan Read
added Technical Writing docsfeature documentation labels
@eread
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @eread
mentioned in issue gitlab-com/www-gitlab-com#13148 (closed)
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Max Woolf
- Resolved by Max Woolf
removed review request for @huzaifaiftikhar1
removed workflowin dev label
added 486 commits
-
3565a28d...d75590f9 - 484 commits from branch
master
- 3db0fe15 - Add auditEventsStreamingHeadersDestroy Mutation
- 6e25b72b - Backend reviewer suggestions
-
3565a28d...d75590f9 - 484 commits from branch
requested review from @huzaifaiftikhar1
removed review request for @huzaifaiftikhar1
- Resolved by Max Woolf
requested review from @huzaifaiftikhar1
requested review from @.luke and removed review request for @huzaifaiftikhar1
- Resolved by Luke Duncalfe
enabled an automatic merge when the pipeline for 87fabe51 succeeds
@mwoolf Looks great
! I've added aChangelog: added
trailer to the squash commit. Thanks @huzaifaiftikhar1 for your review . Set to merge when the pipeline succeeds .mentioned in commit c858bde6
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedpublished label
mentioned in merge request kubitus-project/kubitus-installer!1153 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!106660 (merged)
mentioned in merge request !90717 (merged)
added releasedcandidate label and removed releasedpublished label