Skip to content

Change pending badge and text on members page for awaiting members

Doug Stull requested to merge 361373-update-member-tab-design into master

What does this MR do and why?

  • Changes the Pending owner approval text on awaiting users in the Invited tab to Pending owner action
  • Adds helpful subtext for users who can manage members on the top-level group(namespace)

See spec on https://gitlab.com/gitlab-org/gitlab/-/issues/361373

Screenshots or screen recordings

before after
Screen_Shot_2022-05-24_at_1.37.24_PM Screen_Shot_2022-05-24_at_1.28.47_PM

How to set up and validate locally

  1. Simulate SaaS and restart GDK
  2. Update Application Setting
    bin/rails c
    ApplicationSetting.first.update(check_namespace_plan: true)
  3. Disable the feature flag
    Feature.disable(:free_user_cap)
  4. Create a new group.
  5. Add at least 6 members by username.
  6. Open rails console via bundle exec rails c and change last member's state to awaiting
    member = Member.last
    member.update_column(:state, 1)
  7. Enable the feature flag
    Feature.enable(:free_user_cap)
  8. Refresh the group members page you are on.
  9. Notice the changed text and the badge name on the invited tab for your 6th member.
  10. Repeat similar process for projects that have groups.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #361373

Edited by Doug Stull

Merge request reports