Skip to content
Snippets Groups Projects

Inconsistent focus on the fields when editing a file in SFE

All threads resolved!

What does this MR do and why?

Fixes the focus for the commit message field in SFE.

Screenshots or screen recordings

Before After
SFE_before SFE_after

How to set up and validate locally

  1. Go to Repository > Files
  2. Edit a file
  3. Click on Commit message

Note

There was an overflow: hidden set with the note that it fixes gitlab-foss#13987 (closed) As far as I can tell it seems it is not necessary anymore as removing it will not break the layout on smaller viewports.

Related to #363176 (closed)

Edited by Sascha Eggenberger

Merge request reports

Merged results pipeline #545843088 passed

Pipeline: GitLab

#545865766

    Merged results pipeline passed for 11672ce0

    Test coverage 75.26% (-4.19%) from 2 jobs

    Merged by Denys MishunovDenys Mishunov 2 years ago (May 23, 2022 2:51pm UTC)

    Loading

    Pipeline #545934029 passed

    Pipeline passed for e1b04b33 on master

    Test coverage 79.45% (-4.19%) from 2 jobs
    8 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Denys Mishunov approved this merge request

    approved this merge request

  • Denys Mishunov resolved all threads

    resolved all threads

  • :wave: @dmishunov, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Denys Mishunov enabled an automatic merge when the pipeline for b0568898 succeeds

    enabled an automatic merge when the pipeline for b0568898 succeeds

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 1e13ba9d and 34e4b709

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.46 MB 3.46 MB - -0.0 %
    mainChunk 1.94 MB 1.94 MB - -0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report!

    review-qa-blocking: :exclamation: test report for 34e4b709

    expand test summary
    +-------------------------------------------------------------------+
    |                          suites summary                           |
    +----------------------+--------+--------+---------+-------+--------+
    |                      | passed | failed | skipped | flaky | result |
    +----------------------+--------+--------+---------+-------+--------+
    | Manage               | 36     | 0      | 2       | 38    | ❗     |
    | Create               | 23     | 0      | 2       | 23    | ❗     |
    | Plan                 | 41     | 0      | 1       | 41    | ❗     |
    | Version sanity check | 0      | 0      | 1       | 0     | ➖     |
    | Protect              | 2      | 0      | 0       | 2     | ❗     |
    | Verify               | 12     | 0      | 1       | 12    | ❗     |
    | Package              | 0      | 0      | 1       | 0     | ➖     |
    | Configure            | 0      | 0      | 1       | 0     | ➖     |
    +----------------------+--------+--------+---------+-------+--------+
    | Total                | 114    | 0      | 9       | 116   | ❗     |
    +----------------------+--------+--------+---------+-------+--------+
  • Sascha Eggenberger aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 1 commit

    • 34e4b709 - Fix SFE commit message focus

    Compare with previous version

  • Denys Mishunov resolved all threads

    resolved all threads

  • Denys Mishunov enabled an automatic merge when the pipeline for 11672ce0 succeeds

    enabled an automatic merge when the pipeline for 11672ce0 succeeds

  • Denys Mishunov mentioned in commit e1b04b33

    mentioned in commit e1b04b33

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #363176 (closed)

  • Please register or sign in to reply
    Loading