Inconsistent focus on the fields when editing a file in SFE
What does this MR do and why?
Fixes the focus for the commit message field in SFE.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to Repository > Files
- Edit a file
- Click on Commit message
Note
There was an overflow: hidden
set with the note that it fixes gitlab-foss#13987 (closed)
As far as I can tell it seems it is not necessary anymore as removing it will not break the layout on smaller viewports.
Related to #363176 (closed)
Merge request reports
Activity
added Beautifying our UI UI polish UX devopsfoundations groupcompliance sectiondev typebug + 1 deleted label
requested review from @dmishunov
assigned to @seggenberger
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rymai
,@dzaporozhets
,@mayra-cabrera
,@felipe_artur
,@tigerwnz
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
changed milestone to %15.1
Related to #361641 (closed)
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Alper Akgun ( @a_akgun
) (UTC+3, 1 hour ahead of@seggenberger
)Jacques Erasmus ( @jerasmus
) (UTC+2, same timezone as@seggenberger
)UX Rebecca 'Becka' Lippert ( @beckalippert
) (UTC+0, 2 hours behind@seggenberger
)No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by Denys Mishunov
- Resolved by Denys Mishunov
Great job, @seggenberger! Thank you
@dmishunov
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for b0568898 succeeds
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1e13ba9d and 34e4b709
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.46 MB - -0.0 % mainChunk 1.94 MB 1.94 MB - -0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 34e4b709expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 36 | 0 | 2 | 38 | ❗ | | Create | 23 | 0 | 2 | 23 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | | Configure | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 114 | 0 | 9 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
enabled an automatic merge when the pipeline for 11672ce0 succeeds
mentioned in commit e1b04b33
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedpublished label
mentioned in merge request kubitus-project/kubitus-installer!1153 (merged)
added releasedcandidate label and removed releasedpublished label
mentioned in issue #363176 (closed)