Unbox «Designs»
Merge request reports
Activity
changed milestone to %15.1
assigned to @seggenberger
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @gitlab-bot
,@NikolayS
,@mkozono
,@himkp
,@jannik_lehmann
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Nicolas Dular ( @nicolasdular
) (UTC+2, same timezone as@seggenberger
)Phil Hughes ( @iamphill
) (UTC+1, 1 hour behind@seggenberger
)UX Michael Fangman ( @mfangman
) (UTC-5, 7 hours behind@seggenberger
)No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangermentioned in merge request !87886 (closed)
Related to #361641 (closed)
- Resolved by Robert HuntEdited by Sascha Eggenberger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6206c4ff and ecf58f40
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.46 MB - -0.0 % mainChunk 1.94 MB 1.94 MB - -0.0 %
Note: We do not have exact data for 6206c4ff. So we have used data from: 5d3fc8bc.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for ecf58f40expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Verify | 12 | 0 | 1 | 12 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Manage | 36 | 0 | 2 | 38 | ❗ | | Create | 23 | 0 | 2 | 23 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 114 | 0 | 9 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
removed review request for @rob.hunt
removed review request for @mfangman
@mfangman
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @rob.hunt
- Resolved by Robert Hunt
added 265 commits
-
a616bb4a...0a0c6cb9 - 264 commits from branch
master
- ecf58f40 - Unbox Designs on issues
-
a616bb4a...0a0c6cb9 - 264 commits from branch
enabled an automatic merge when the pipeline for 9c86a5a8 succeeds
mentioned in commit e43aa2f6
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedpublished label
mentioned in merge request kubitus-project/kubitus-installer!1153 (merged)
mentioned in issue #366325 (closed)
added releasedcandidate label and removed releasedpublished label