Skip to content

Import JiHu svgs vendor when in JH edition

Kun Qian requested to merge gitlab-jh/jh-team/gitlab:add-jh-svgs-to-rails into master

What does this MR do and why?

Considering there will be JH specific svg files, JH is going to publish @jihulab/svgs and use in code in /jh folder, check details why and how we do this in https://gitlab.com/gitlab-jh/gitlab-jh-enablement/-/issues/170. In order to make the package work in rails, we need to add module path to Rails assets path, and precompile the JH specific svg files.

/cc @daveliu

Screenshots or screen recordings

How to set up and validate locally

  1. create node_modules/@jihulab/svgs/dist/illustrations/jh/test.svg
  2. start rails
  3. use the file added

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kun Qian

Merge request reports