Skip to content

Use GitLab UI radio button component for Project Merge Request settings' Merge Method section

Thomas Randolph requested to merge tor/maintenance/pajamas-conversion/mr-settings-merge-method into master

For #361137 (closed)

Why

Part of the department-wide Pajamas conversion OKR.

What

I converted HTML to a special function that renders HTML.

Verify

  1. Go to a project that you have admin rights for
  2. Click to the General settings for the project (left nav)
  3. Open the "Merge requests" section
  4. The first sub-section is "Merge method"

Caveats

The special function has a help_text argument that renders some subtext below the radio input.
However, it's not very well-suited to more than a single line of text, so it's pretty clunky to represent that as a single argument.

It seems that <br /> elements have different heights in the new output (in a <p>) versus the old output (in an implicit <div>). ¯\＿(ツ)＿/¯

Screenshots

Before After
before after
Edited by Thomas Randolph

Merge request reports