Skip to content

Update license_compliance.rb to fix FF tests

Will Meek requested to merge update-licence-compliance-qa into master

This fixes #362833 (closed) , was introduced as part of a bad post-initial-review-change copy-paste.

Testing:

Test with FF enabled and disabled. (You may wish to add a pry point to qa/qa/ee/page/project/secure/license_compliance.rb ln 36/58 to prove which radio button element is found/used)

disable (uses old approved/blacklisted)

bundle exec bin/qa Test::Instance::All --disable-feature lc_remove_legacy_approval_status https://staging.gitlab.com qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb
[date=2022-05-19 09:20:46 from=QA Tests] DEBUG -- found :approved_license_radio
[date=2022-05-19 09:20:46 from=QA Tests] DEBUG -- approved_license_radio was selected
...
[date=2022-05-19 09:21:05 from=QA Tests] DEBUG -- found :blacklisted_license_radio
[date=2022-05-19 09:21:05 from=QA Tests] DEBUG -- blacklisted_license_radio was selected

enable (uses FF allowed/denied)

bundle exec bin/qa Test::Instance::All --enable-feature lc_remove_legacy_approval_status https://staging.gitlab.com qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb
[date=2022-05-19 09:23:45 from=QA Tests] DEBUG -- found :allowed_license_radio
[date=2022-05-19 09:23:45 from=QA Tests] DEBUG -- allowed_license_radio was selected
...
[date=2022-05-19 09:23:48 from=QA Tests] DEBUG -- found :denied_license_radio
[date=2022-05-19 09:23:48 from=QA Tests] DEBUG -- denied_license_radio was selected
Edited by Will Meek

Merge request reports