Skip to content

Contribution Analytics - Deprecate seg control

Zack Cuddy requested to merge 348104-deprecate-date_selector.vue into master

What does this MR do and why?

Closes #348104 (closed)
Work towards Q2 OKR: #360715 (closed)

This change deprecates the segmented control in date_selector.vue for the contribution analytics. We instead will now use gl_tabs_nav in HAML and can remove the JS entirely 🎉

Screenshots or screen recordings

Before After
No Param No_Param_-_Before No_Param_-_After
Last Week Last_Week_-_Before Last_Week_-_After
Last Month Last_Month_-_Before Last_Month_-_After
Last 3 Months Last_3_Months_-_Before Last_3_Months_-_After
Custom Date Hard_Coded_Date_-_Before Custom_Date_-_After
Mobile Mobile_-_Before Mobile_-_After

How to set up and validate locally

  1. Go to a Group page
  2. Click the Analytics tab -> Contribution
  3. Ensure default Last Week is selected in date tab
  4. Cycle through the options and ensure they behave as expected

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zack Cuddy

Merge request reports