Skip to content

Add end-to-end QA spec for serving metrics

Matthias Käppler requested to merge 356982-metrics-qa-tests into master

We want to make sure we end-to-end test our various /metrics endpoints scraped by Prometheus. These are absolutely critical for a deployment to be successful, and we had incidents in the past where problems with these went undetected.

This MR builds on gitlab-qa!1016 (merged) (and related MRs) to add a QA spec, which:

  • runs the application in a Docker instances where dedicated metrics servers are spawned for Sidekiq and Puma
  • sends an HTTP request to the /metrics endpoints and sanity-checks the rendered metrics text

I have marked the test for the /-/metrics Rails route pending because this is behind an authentication check that is difficult to include. It's not that important anyway since we do not use this endpoint for SaaS.

Related to #356982 (closed)

Edited by Matthias Käppler

Merge request reports