Skip to content
Snippets Groups Projects

Fix failing epics finder spec

Merged Jan Provaznik requested to merge jp-fix-epicspec into master
All threads resolved!

There is still N+1 query issue which needs to be taken into account in the N+1 test, it was passing before probably because missing warm-up.

Related to #362682 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    @engwan could you please do maintainer review? (given that this is a spec only change which just narrows control count I think we can jump directly to maintainer review)

  • Jan Provaznik requested review from @engwan

    requested review from @engwan

  • Heinrich Lee Yu resolved all threads

    resolved all threads

  • Heinrich Lee Yu approved this merge request

    approved this merge request

  • Heinrich Lee Yu enabled an automatic merge when the pipeline for 4dfd1bc1 succeeds

    enabled an automatic merge when the pipeline for 4dfd1bc1 succeeds

  • :wave: @engwan, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Suggested Reviewers (beta)

    The individuals below may be good candidates to participate in the review based on various factors.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Suggested Reviewers
    @dskim_gitlab, @ashmckenzie, @psimyn, @alexbuijs, @pbair

    If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

  • Jan Provaznik resolved all threads

    resolved all threads

  • 2 Warnings
    :warning: Please add a merge request type to this merge request.
    :warning: This merge request does not refer to an existing milestone.
    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Roy Zwambag (@rzwambag) (UTC+2, same timezone as @jprovaznik) Thong Kuah (@tkuah) (UTC+12, 10 hours ahead of @jprovaznik)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Generated by :no_entry_sign: Danger

  • Rémy Coutable changed milestone to %15.1

    changed milestone to %15.1

  • Etienne Baqué mentioned in merge request !87806 (merged)

    mentioned in merge request !87806 (merged)

  • Heinrich Lee Yu mentioned in commit ad0d820d

    mentioned in commit ad0d820d

  • Bob Van Landuyt mentioned in merge request !87577 (merged)

    mentioned in merge request !87577 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading