Fix finding downstream pipeline by title
Related to #361338 (closed), #361346 (closed), #361339 (closed)
We were looking for downstream pipelines using title attribute but it was removed here. The main purpose of this MR is to address that. I also try to have all the jobs in 1 stage so that they can all start at the same time and hopefully yield less test runtime.
And since I made some changes around api_variable_inheritance_with_forward_pipeline_variables_spec.rb
, I also lift its quarantine here as well. I want to put it into the transient bucket for better monitoring with the new wait logics. This is related to #361400 (closed)
Merge request reports
Activity
added QA Quality failureinvestigating found:main found:nightly priority2 ~17053143 ~24217784 test labels
assigned to @treagitlab
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @john.mcdonnell
,@sliaquat
,@mlapierre
,@acunskis
,@a_mcdonald
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botmentioned in issue #361346 (closed)
changed milestone to %15.1
1 Warning 36d54cd2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Payton Burdette ( @pburdette
) (UTC-4, 3 hours ahead of@treagitlab
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 12.5 hours ahead of@treagitlab
)QA Will Meek ( @willmeek
) (UTC+1, 8 hours ahead of@treagitlab
)Anastasia McDonald ( @a_mcdonald
) (UTC+12, 19 hours ahead of@treagitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by Anastasia McDonald
removed failureinvestigating label
added failurestale-test grouppipeline authoring typemaintenance labels
- Resolved by Anastasia McDonald
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 55bca8a4 and c20944c2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.46 MB - 0.0 % mainChunk 1.94 MB 1.94 MB - 0.0 %
Note: We do not have exact data for 55bca8a4. So we have used data from: 329bf0f7.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in issue #361400 (closed)
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for c20944c2expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 23 | 0 | 2 | 23 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Manage | 36 | 0 | 2 | 38 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 114 | 0 | 9 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
package-and-qa:
test report for c20944c2expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 763 | 5 | 36 | 40 | ❌ | | Manage | 471 | 0 | 30 | 0 | ✅ | | Plan | 273 | 0 | 0 | 6 | ❗ | | Fulfillment | 11 | 0 | 55 | 0 | ✅ | | Verify | 185 | 5 | 15 | 20 | ❌ | | Package | 149 | 0 | 30 | 35 | ❗ | | Protect | 10 | 0 | 0 | 0 | ✅ | | Secure | 95 | 0 | 10 | 35 | ❗ | | Release | 30 | 0 | 0 | 0 | ✅ | | Non-devops | 11 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 5 | 5 | ➖ | | Configure | 1 | 0 | 15 | 0 | ✅ | | Enablement:Search | 9 | 0 | 1 | 0 | ✅ | +----------------------+--------+--------+---------+-------+--------+ | Total | 2008 | 10 | 197 | 141 | ❌ | +----------------------+--------+--------+---------+-------+--------+
added sectionops label
added 137 commits
-
9c2bbc42...a430cca9 - 136 commits from branch
master
- 1a889f56 - Fix finding downstream pipeline by title
-
9c2bbc42...a430cca9 - 136 commits from branch
- The
gitlab-qa-mirror
downstream pipeline for !87832 (1a889f56) failed! - The
gitlab-qa-mirror
downstream pipeline for !87832 (e6597917) failed! - The
gitlab-qa-mirror
downstream pipeline for !87832 (e6597917) passed. - The
gitlab-qa-mirror
downstream pipeline for !87832 (d73fcb46) passed. - The
gitlab-qa-mirror
downstream pipeline for !87832 (d73fcb46) failed! - The
gitlab-qa-mirror
downstream pipeline for !87832 (c20944c2) failed!
- The
- Resolved by Anastasia McDonald
@john.mcdonnell would you do the first review here? The unquarantined tests are passing in the last pipeline
requested review from @john.mcdonnell
- Resolved by Tiffany Rea
- Resolved by Tiffany Rea
@john.mcdonnell
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 561 commits
-
e6597917...09b15db1 - 559 commits from branch
master
- dcd63aa6 - Fix finding downstream pipeline by title
- d73fcb46 - Add transient trials
-
e6597917...09b15db1 - 559 commits from branch
- Resolved by Anastasia McDonald
@a_mcdonald over to you for maintainer review
requested review from @a_mcdonald
mentioned in merge request !88193 (merged)
enabled an automatic merge when the pipeline for 617925d9 succeeds
added 242 commits
-
d73fcb46...55bca8a4 - 240 commits from branch
master
- 36d54cd2 - Fix finding downstream pipeline by title
- c20944c2 - Add transient trials
-
d73fcb46...55bca8a4 - 240 commits from branch
enabled an automatic merge when the pipeline for 8b3a39d5 succeeds
mentioned in commit 0e57c97c
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #361339 (closed)
mentioned in issue #361338 (closed)
added releasedpublished label
added releasedcandidate label and removed releasedpublished label