Freeze time in metrics value expectation
What does this MR do and why?
See: #362591 (closed)
This fixes a master:broken issue with an unreliable spec.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @alexkalderimis
/cc @kwiebers
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dstull
,@pskorupa
,@ahegyi
,@dgruzd
,@.luke
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- Resolved by Etienne Baqué
@dstull - The ML oracle seems to think you would be a good reviewer for this. Would you be able to take a look?
requested review from @dstull
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Allen Cook ( @acook.gitlab
) (UTC-4, same timezone as@alexkalderimis
)Etienne Baqué ( @ebaque
) (UTC+3, 7 hours ahead of@alexkalderimis
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerchanged milestone to %15.1
added typemaintenance label
@dstull
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added groupintegrations [DEPRECATED] label
enabled an automatic merge when the pipeline for a8421c4f succeeds
- Resolved by Etienne Baqué
The failing job is related to another broken spec, which is being fixed here.
added 141 commits
-
6d45088d...ad0d820d - 140 commits from branch
master
- 0b1f1bc4 - Freeze time in metrics value expectation
-
6d45088d...ad0d820d - 140 commits from branch
added 5 commits
-
0b1f1bc4...b003ead8 - 4 commits from branch
master
- 12e84b6b - Freeze time in metrics value expectation
-
0b1f1bc4...b003ead8 - 4 commits from branch
enabled an automatic merge when the pipeline for 365f8ede succeeds
mentioned in commit 95045d9f
added workflowstaging-canary label
mentioned in issue #362591 (closed)
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label
added pipelineexpedited label