Skip to content

Refactor storage helper date checking

Vijay Hawoldar requested to merge vij-bypass-storage-banner-dates into master

What does this MR do and why?

In order to allow us to bypass the date checking for storage banner info, this MR refactors the storage helper to check a feature flag to determine if we should check the dates or not.

We are doing similar in the RootStorageSize for the same purpose - to enable testing on staging/prod for select test groups

The namespace_storage_limit_bypass_date_check feature flag can be re-used here because it's sole purpose is for testing.

This MR also modifies the helper slightly to allow it to work with sub-groups.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. Enable the feature flag 
    Feature.enable(:namespace_storage_limit_bypass_date_check)
  2. View a relevant screen for a free group (e.g. usage quotas) and view the banner

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vijay Hawoldar

Merge request reports