Skip to content

Add test case for the tag index page

Shinya Maeda requested to merge corrective-action-tag-index-page into master

What does this MR do and why?

This is corrective action for the recent incident on tag index page.

corrective action Add a test case that passes a slashed tag name (e.g. v0.1/test) as a route parameter. spec/controllers/projects/tags_controller_spec.rb would be a good place for this.

This prevents the same incident from happening.

This also adds a basic coverage to the feature specs. It seems we don't have any coverage at the moment.

Related https://gitlab.com/gitlab-com/gl-infra/production/-/issues/7069

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports