Add copy button to snippet

assigned to @mle

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
`@pslaughter`, `@rspeicher`, `@dmishunov`, `@dbalexandre`, `@rymai`

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

3 Warnings

: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

This merge request does not refer to an existing milestone.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

If needed, you can retry the danger-review job that generated this comment.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Minahil Nichols (`@minahilnichols`) (UTC-4, 14 hours behind `@mle`)	Kerri Miller (`@kerrizor`) (UTC-7, 17 hours behind `@mle`)
frontend	Miranda Fluharty (`@mfluharty`) (UTC-6, 16 hours behind `@mle`)	Mike Greiling (`@mikegreiling`) (UTC-5, 15 hours behind `@mle`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

changed the description

@oregand I need some assistance trying to figure out how to do the following things to complete this MR. If you could help direct me to someone of context of this functionality that would be great.

How do I implement "copy to clipboard" in Ruby?

I started a function here !87677 (diffs) in snippets_helper.rb but I am not sure of how to get context of file and how to fill the clipboard

The icon of the button is not correct.

I don't know how the icon loading works. I am assuming it uses app/helpers/icons_helper.rb but it appears copy-to-clipboard is not there.

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for de1c8412

expand test summary

+-------------------------------------------------------------------+
|                          suites summary                           |
+----------------------+--------+--------+---------+-------+--------+
|                      | passed | failed | skipped | flaky | result |
+----------------------+--------+--------+---------+-------+--------+
| Plan                 | 41     | 0      | 1       | 41    | ❗     |
| Create               | 22     | 0      | 3       | 23    | ❗     |
| Manage               | 35     | 0      | 3       | 38    | ❗     |
| Verify               | 12     | 0      | 1       | 12    | ❗     |
| Configure            | 0      | 0      | 1       | 0     | ➖     |
| Version sanity check | 0      | 0      | 1       | 0     | ➖     |
| Package              | 0      | 0      | 1       | 0     | ➖     |
| Protect              | 2      | 0      | 0       | 2     | ❗     |
+----------------------+--------+--------+---------+-------+--------+
| Total                | 112    | 0      | 11      | 116   | ❗     |
+----------------------+--------+--------+---------+-------+--------+

added 1 commit

c03c46ba - Add functionality to copy to clipboard

Compare with previous version

changed the description

Should we be moving forward with this merge request?

To make the copy to clipboard work I am using ClipboardJS. We are using this library in other parts of the application but through existing helper files like:

app/assets/javascripts/behaviors/copy_to_clipboard.js
app/helpers/button_helper.rb

There is currently NO JavaScript as part of the embed snippet code.

The snippet delivered on a page via a Ruby router that renders this information app/views/shared/snippets/show.js.haml The HTML and CSS to give the embed the correct layout and functionality are delivered as part of page. The existing functionality of viewing the raw file or viewing the source are done with links.

By introducing the "copy to clipboard" functionality I had to introduce a third party JavaScript library on the page (Ln 1) because this functionality is not possible using vanilla JavaScript.

The concern I have is that by loading a snippet on the page, page load is taking an extra hit by loading a 3rd party JavaScript library.

Is there a way to work around this dependency of a 3rd party library?

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 12cc4ea4 and de1c8412

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.46 MB	3.46 MB	-	0.0 %
mainChunk	1.93 MB	1.93 MB	-	0.0 %

Note: We do not have exact data for 12cc4ea4. So we have used data from: 97d29dc2.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Add copy button to snippet

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Activity

Suggested Reviewers (beta)

Reviewer roulette

Allure report

Should we be moving forward with this merge request?

Bundle size analysis [beta]

Special assets

Add copy button to snippet

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Merge request reports

Activity

Suggested Reviewers (beta)

Reviewer roulette

Allure report

Should we be moving forward with this merge request?

Bundle size analysis [beta]

Special assets