Skip to content

Resolve "Images polute ipynb diff"

Eduardo Bonet requested to merge 361843-images-polute-ipynb-diff into master

What

Jupyter Notebooks embed images as base64. Being able to diffing image changes can be really useful, but since we are only displaying diffs as text for now it just adds noise and no information.

Screenshots

Before After
image image

How to reproduce

  1. Make sure that the FF is on Feature.enable(:ipynb_semantic_diff)
  2. Open a commit with a notebook (eg https:///gitlab-org/gitlab-test/-/commit/5d6ed1503801ca9dc28e95eeb85a7cf863527aee#56a47b92c949c701e3e7c1a10675e8dc8b66ee4a_68_56)
  3. Instead of the base64 of the image, the diff should display [Hidden Image Output]

Related to #361843 (closed)

Edited by Eduardo Bonet

Merge request reports