Skip to content

Dequarantine License Compliance specs

Will Meek requested to merge deq_license_specs_ff into master

Dequarantine tests which were quarantined as per !87340 (merged)

There was a UI change behind a feature flag. Originally the intention was to check for this FF, however it appeared that this would be more involved than originally thought.

This MR adds a function to check for feature flag enabled radio buttons, use them if present, otherwise use the non-FF versions.

Testing:

Test with FF enabled and disabled. (You may wish to add a pry point to qa/qa/ee/page/project/secure/license_compliance.rb ln 36/58 to prove which radio button element is found/used)

disable (uses old approved/blacklisted)

bundle exec bin/qa Test::Instance::All --disable-feature lc_remove_legacy_approval_status https://staging.gitlab.com qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb

enable (uses FF allowed/denied)

bundle exec bin/qa Test::Instance::All --enable-feature lc_remove_legacy_approval_status https://staging.gitlab.com qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb

Merge request reports