Add skeleton loader for usage_quota's storage
What does this MR do and why?
- Adds a skeleton loader to statistics-card giving more useful feedback to users, and update namespace storage app to utilize it
- Refactor
storage_usage_statistics_spec.js
to usecreateMockApollo
Screenshots or screen recordings
loading | loaded | with error |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
- Navigate to a group's usage quota > storage
- Observe the loader after the page loads
- (alternatively from Vue DevTools locate
<storage-usage-statistics>
and manually update itsloading
prop) - To test the error alert you can mess the
ee/app/assets/javascripts/usage_quotas/storage/queries/namespace_storage.query.graphql
query to throw an error (like rename$fullPath
to some gibberish )
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #356659 (closed)
Merge request reports
Activity
changed milestone to %15.1
added frontend grouputilization sectionfulfillment labels
assigned to @aalakkad
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dbalexandre
,@mayra-cabrera
,@marin
,@dzaporozhets
,@tkuah
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot2 Warnings This merge request is quite big (629 lines changed), please consider splitting it into multiple merge requests. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Angelo Gulina ( @agulina
) (UTC+2, 1 hour behind@aalakkad
)Andrew Fontaine ( @afontaine
) (UTC-4, 7 hours behind@aalakkad
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 1 commit
- ad642f86 - Add loadingError state to namespace storage app
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c61666f5 and b4629ae0
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.54 MB 3.54 MB - 0.0 % mainChunk 1.98 MB 1.98 MB - 0.0 %
Note: We do not have exact data for c61666f5. So we have used data from: 2e888a8a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for b4629ae0expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 8 | 25 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 48 | 0 | 1 | 8 | 49 | ❗ | | Verify | 12 | 0 | 1 | 2 | 13 | ❗ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 37 | 0 | 2 | 4 | 39 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 24 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
Setting label(s) ~"Category:Utilization" devopsfulfillment based on grouputilization.
added devopsfulfillment + 1 deleted label
added 271 commits
-
ad642f86...96137db2 - 269 commits from branch
master
- 644b091e - Add skeleton loader for usage_quota's storage
- 68aa4262 - Add loadingError state to namespace storage app
-
ad642f86...96137db2 - 269 commits from branch
added 1160 commits
-
68aa4262...3ef9bea8 - 1158 commits from branch
master
- f88527a8 - Add skeleton loader for usage_quota's storage
- 76cccc73 - Add loadingError state to namespace storage app
-
68aa4262...3ef9bea8 - 1158 commits from branch
- Resolved by 🤖 GitLab Bot 🤖
@aalakkad - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
added featureenhancement typefeature labels