Skip to content

Add scanner|site profiles editing form to the sidebar

Artur Fedorov requested to merge 362010-add-profile-editing-form into master

What does this MR do and why?

This MR resolves #362010 (closed)

  1. This MR adds scanner|site profile editing form to sidebar according to new design
  2. This MR handles only editing of existing profile
  3. Refetching of profiles will be adjusted in another MR
  4. List of created profiles in the sidebar will be added in another MR after this MR is merged
  5. dast_scanner_profile_form and dast_site_profile_form already handle editing functionality. profile property need to be provided.
  6. Enabling edit form from summary card wi be added in another MR

Describe in detail what your merge request does and why.

Screenshots or screen recordings

After
Screenshot_2022-05-12_at_15.51.54
-----
sidebar_loaders

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. Enable feature flag
   Feature.enable(:dast_ui_redesign)
  1. Go to any project /root/$PROJECT_ID/
  2. Go to /root/$PROJECT_ID/-/on_demand_scans/
  3. Go to new scan form by clicking new scan
  4. You have to have all scanners deleted, so you can see empty state
  5. Click Select scanner|site profile

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Artur Fedorov

Merge request reports