Fix assignee filtering on group/project issues list
What does this MR do and why?
Issue: On the group/project issues page, filtering by numerical assignees (e.g. Assignee = 5
) filters the list incorrectly. The GraphQL query filters by assignee_id=5
because we have a feature spec that asserts we should do this when the url param assignee_id=5
exists.
This MR fixes this to allow the user to filter by numerical assignees, which is how it worked on the Haml version before the Vue refactor. When this happens, the GraphQL query instead correctly filters by assignee_usernames=5
.
Fixes #360736 (closed)
Screenshots or screen recordings
before | after | |
---|---|---|
assignee_id URL param |
Same ![]() |
Same ![]() |
filtering by Assignee token |
![]() |
![]() |
How to set up and validate locally
- Make sure you have a user with a numerical username
- Visit any group or project issues list page such as
http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues
- Test the MR
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Coung Ngo