Skip to content

Source Editor: The toolbar integration

Denys Mishunov requested to merge 280800-integration into master

This is the last MR in the series aiming at implementing the toolbar MVC for the Source Editor:

What does this MR do?

How to test?

  • In Rails console (rails c), enable the source_editor_toolbar feature flag for your user ('root' in the example below):
[1] pry(main)> Feature.enable(:source_editor_toolbar, User.find_by_username("root"))
  • Go to a repository
  • Pick an .md file in the repository and open it
  • Click "Edit" to edit this markdown file
  • You should notice the toolbar and the button as presented on the picture below

Screenshot_2022-05-10_at_20.17.41

  • You should be able to toggle the live preview by doing both:
    • toggle the button by clicking on it: toggles the preview panel and marks the button as active
    • Screenshot_2022-05-10_at_20.19.21
    • toggle the contextual "Preview Markdown" action
    • Screenshot_2022-05-10_at_20.20.27
    • In both cases, the result should be identical: the preview panel is toggled and the live-preview enabled/disabled

Related to #280800 (closed)

Edited by Denys Mishunov

Merge request reports

Loading